Revert 201510 "Revert 201498 "Add devtools instrumentation for c..."
commit7f395143530576523fc93312ce813492cb4a5ee4
authorjohnme@chromium.org <johnme@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Wed, 22 May 2013 15:45:03 +0000 (22 15:45 +0000)
committerjohnme@chromium.org <johnme@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Wed, 22 May 2013 15:45:03 +0000 (22 15:45 +0000)
treeb0ea884442c421ea144e3bccd1b84ceb0bad9dd2
parentb9417cb44cfc56892248f554fee9c152ddb1f2c0
Revert 201510 "Revert 201498 "Add devtools instrumentation for c..."

Reverting this didn't fix the build, instead it turned out that crrev.com/201513
fixed the build. Hence I'm reverting this revery :-)

> Revert 201498 "Add devtools instrumentation for canvas creation ..."
>
> This is a speculative revert to try and fix build breakage starting with:
> http://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/10905
>
> If it doesn't help, this revert should be reverted :-)
>
> > Add devtools instrumentation for canvas creation in BitmapContentLayerUpdater
> >
> > Canvas bitmap allocation may take considerable time (close to that of
> > actual layer update), so having it intrumented helps to reduce "unknown"
> > time on Timeline.
> >
> > - keep layer id in content layer updater, plumb it through all
> >     content layer updaters.
> > - extract boilerplate of devtools instrumentation classes to a macro;
> > - add instrumentation around canvas bitmap allocation in
> >     BitmapContentLayerUpdater.
> >
> > Related blink change: https://codereview.chromium.org/15466005
> >
> > R=nduca@chromium.org
> >
> > Review URL: https://codereview.chromium.org/15317008
>
> TBR=caseq@google.com
>
> Review URL: https://codereview.chromium.org/15697005

TBR=johnme@chromium.org

Review URL: https://codereview.chromium.org/15734009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201536 0039d316-1c4b-4281-b951-d872f2087c98
17 files changed:
cc/debug/devtools_instrumentation.h
cc/layers/content_layer.cc
cc/layers/content_layer_unittest.cc
cc/layers/picture_layer.cc
cc/layers/scrollbar_layer.cc
cc/layers/tiled_layer_unittest.cc
cc/resources/bitmap_content_layer_updater.cc
cc/resources/bitmap_content_layer_updater.h
cc/resources/bitmap_skpicture_content_layer_updater.cc
cc/resources/bitmap_skpicture_content_layer_updater.h
cc/resources/caching_bitmap_content_layer_updater.cc
cc/resources/caching_bitmap_content_layer_updater.h
cc/resources/content_layer_updater.cc
cc/resources/content_layer_updater.h
cc/resources/skpicture_content_layer_updater.cc
cc/resources/skpicture_content_layer_updater.h
cc/resources/tile_manager.cc