| commit | 7f59ee147777a9df9e5a83462c6a230ad060e81e | |
| author | davidben <davidben@chromium.org> | |
| Fri, 10 Jul 2015 17:21:57 +0000 (10 10:21 -0700) | ||
| committer | Commit bot <commit-bot@chromium.org> | |
| Fri, 10 Jul 2015 17:22:38 +0000 (10 17:22 +0000) | ||
| tree | 72ad6300fd55334eb9513e993d730e27af93d5ed | treesnapshot (tar.gz zip) |
| parent | ef0b43b102ce6999c847e46d5663ad2d5c826507 | commitdiff |
Remove incorrect DCHECK in ~BrowserCdmManager.
https://codereview.chromium.org/1225083002 fixed the core issue but left an
incorrect DCHECK in the code. It is not the case that only a single
BrowserCdmManager per RPH ID may be alive at a time, only that a single one
corresponds to a given live process. (A reference-counted type can never be
assumed to have bounded lifetime for the same reason garbage-collected types
can never be assumed to have bounded lifetime.)
This fixes ChildProcessLauncherBrowserTest.ChildSpawnFail's flakiness on
cast_shell_linux when use_openssl is switched.
BUG=506188,462040
Review URL: https://codereview.chromium.org/1235653002
Cr-Commit-Position: refs/heads/master@{#338312}
https://codereview.chromium.org/1225083002 fixed the core issue but left an
incorrect DCHECK in the code. It is not the case that only a single
BrowserCdmManager per RPH ID may be alive at a time, only that a single one
corresponds to a given live process. (A reference-counted type can never be
assumed to have bounded lifetime for the same reason garbage-collected types
can never be assumed to have bounded lifetime.)
This fixes ChildProcessLauncherBrowserTest.ChildSpawnFail's flakiness on
cast_shell_linux when use_openssl is switched.
BUG=506188,462040
Review URL: https://codereview.chromium.org/1235653002
Cr-Commit-Position: refs/heads/master@{#338312}
| content/browser/media/cdm/browser_cdm_manager.cc | diffblobblamehistory |