| commit | 80ae334666f8f50250d7146228c39a2ecd9f5cb1 | |
| author | felt@chromium.org <felt@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Mon, 4 Nov 2013 21:34:19 +0000 (4 21:34 +0000) | ||
| committer | felt@chromium.org <felt@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Mon, 4 Nov 2013 21:34:19 +0000 (4 21:34 +0000) | ||
| tree | 2a7a0234bb1af27c82cee8017812dd6eb908d1fa | treesnapshot (tar.gz zip) |
| parent | 65330ec4ee362571bbb92b02e8a055b3c43fd3ab | commitdiff |
Fix the SSL interstitial UMA stats
Just discovered that I broke the UMA stats during one of my recent refactorings. Here's what went wrong:
The interstitial is supposed to send a FOCUS event to indicate that page load timing should start. RecordSSLBlockingPageDetailedStats only records UMA stats if the page has a non-null page load time. At some point, I deleted the code that sent the FOCUS event, so the page load time was always null.
We don't need any of the timing stuff anymore, so I've gotten rid of all of it. This also fixes the bug.
BUG=314416
Review URL: https://codereview.chromium.org/57183002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232809 0039d316-1c4b-4281-b951-d872f2087c98
Just discovered that I broke the UMA stats during one of my recent refactorings. Here's what went wrong:
The interstitial is supposed to send a FOCUS event to indicate that page load timing should start. RecordSSLBlockingPageDetailedStats only records UMA stats if the page has a non-null page load time. At some point, I deleted the code that sent the FOCUS event, so the page load time was always null.
We don't need any of the timing stuff anymore, so I've gotten rid of all of it. This also fixes the bug.
BUG=314416
Review URL: https://codereview.chromium.org/57183002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232809 0039d316-1c4b-4281-b951-d872f2087c98
| chrome/browser/resources/ssl/ssl_errors_common.js | diffblobblamehistory | |
| chrome/browser/ssl/ssl_blocking_page.cc | diffblobblamehistory | |
| chrome/browser/ssl/ssl_blocking_page.h | diffblobblamehistory |