| commit | 81f54d7a8cd88c5a8a7e40c858bf342eec68d6ab | |
| author | jsbell <jsbell@chromium.org> | |
| Tue, 25 Aug 2015 18:55:43 +0000 (25 11:55 -0700) | ||
| committer | Commit bot <commit-bot@chromium.org> | |
| Tue, 25 Aug 2015 18:56:20 +0000 (25 18:56 +0000) | ||
| tree | 755573e30890e59b94c43fe3cbb4b9aa1b8e40f9 | treesnapshot (tar.gz zip) |
| parent | 289d1f6ba870b30cbf4a19d114b2ee4fc23f893f | commitdiff |
Simplify browsing data helpers for storage types
The BrowsingDataXXXHelper classes are used by chrome/ to query
content/ for the usage (origins, sizes, last modified times, etc) of
various storage types (cookies, local storage, indexed db, etc). These
helpers followed a pattern of storing local state (`is_fetching_`) the
results (`xxx_info_`) and continuation (`calllback_`) while thread
hopping (UI->IO->UI) and asynchronously querying.
Simplify the classes by passing the information along in closures and
eliminate relay methods where possible. Also, simplify some of the
content/public struct definitions these helpers consume.
(The Quota and AppCache helpers are more complex and will be tackled later.)
BUG=524222
Review URL: https://codereview.chromium.org/1310273003
Cr-Commit-Position: refs/heads/master@{#345397}
The BrowsingDataXXXHelper classes are used by chrome/ to query
content/ for the usage (origins, sizes, last modified times, etc) of
various storage types (cookies, local storage, indexed db, etc). These
helpers followed a pattern of storing local state (`is_fetching_`) the
results (`xxx_info_`) and continuation (`calllback_`) while thread
hopping (UI->IO->UI) and asynchronously querying.
Simplify the classes by passing the information along in closures and
eliminate relay methods where possible. Also, simplify some of the
content/public struct definitions these helpers consume.
(The Quota and AppCache helpers are more complex and will be tackled later.)
BUG=524222
Review URL: https://codereview.chromium.org/1310273003
Cr-Commit-Position: refs/heads/master@{#345397}
47 files changed: