| commit | 8bc4d57eb2d933c180106943e58ca7d1ea83081c | |
| author | calamity <calamity@chromium.org> | |
| Thu, 11 Jun 2015 04:48:04 +0000 (10 21:48 -0700) | ||
| committer | Commit bot <commit-bot@chromium.org> | |
| Thu, 11 Jun 2015 04:48:33 +0000 (11 04:48 +0000) | ||
| tree | 6f2c1a8f2bbfb580e3e0a05181bb8f2a718930de | treesnapshot (tar.gz zip) |
| parent | 6063e8bb90fec5e53b5b1187de367b9d3adb68b9 | commitdiff |
Fix WindowModalityController's GetModalTransientChild[Ash]
This CL fixes an issue where menus would break dialog modality, allowing a
non-modal view to get focus, causing input to be blocked for the whole system.
This would arise when comboboxes were used in modal dialogs.
This has been fixed by making the modal transient child check
return the lowest modal transient in the window tree rather
than null when the leaf nodes of the tree weren't modal.
BUG=456697
Review URL: https://codereview.chromium.org/1161233004
Cr-Commit-Position: refs/heads/master@{#333893}
This CL fixes an issue where menus would break dialog modality, allowing a
non-modal view to get focus, causing input to be blocked for the whole system.
This would arise when comboboxes were used in modal dialogs.
This has been fixed by making the modal transient child check
return the lowest modal transient in the window tree rather
than null when the leaf nodes of the tree weren't modal.
BUG=456697
Review URL: https://codereview.chromium.org/1161233004
Cr-Commit-Position: refs/heads/master@{#333893}
| ash/wm/window_modality_controller_unittest.cc | diffblobblamehistory | |
| ui/wm/core/window_modality_controller.cc | diffblobblamehistory |