Componentize SigninManager.
commit8bd5938206ed01f45172f423cd26889404800d3d
authorblundell@chromium.org <blundell@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Mon, 31 Mar 2014 20:34:44 +0000 (31 20:34 +0000)
committerblundell@chromium.org <blundell@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Mon, 31 Mar 2014 20:34:44 +0000 (31 20:34 +0000)
tree8304f29a5f38b9bc761d8324d3eb0bde3972e8a3
parentbd600527b06a390fc8a1e87cb42e3dda967ff5bc
Componentize SigninManager.

This CL does the following:

- Componentizes SigninIdAccountHelper, on which SigninManager depends
- Abstracts SigninManager's (embedder-level) calculation of whether to merge
  signin credentials into the cookie jar via SigninClient
- Eliminates the |profile| argument of SigninManagerBase::Initialize() now that
  SigninManager no longer needs it
- Componentizes SigninManager

BUG=334209,333998
TBR=thakis

Review URL: https://codereview.chromium.org/218713002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260636 0039d316-1c4b-4281-b951-d872f2087c98
138 files changed:
chrome/browser/android/bookmarks/bookmarks_bridge.cc
chrome/browser/android/signin/signin_manager_android.cc
chrome/browser/app_controller_mac.mm
chrome/browser/autocomplete/search_provider_unittest.cc
chrome/browser/chrome_content_browser_client.cc
chrome/browser/chromeos/app_mode/startup_app_launcher.cc
chrome/browser/chromeos/drive/drive_integration_service.cc
chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc
chrome/browser/chromeos/login/login_utils.cc
chrome/browser/chromeos/login/oauth2_login_manager.cc
chrome/browser/chromeos/login/oauth2_login_verifier.cc
chrome/browser/chromeos/login/screen_locker.cc
chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos_unittest.cc
chrome/browser/chromeos/policy/user_cloud_policy_token_forwarder.cc
chrome/browser/chromeos/policy/user_cloud_policy_token_forwarder_factory.cc
chrome/browser/extensions/api/enterprise_platform_keys_private/enterprise_platform_keys_private_api.cc
chrome/browser/extensions/api/feedback_private/feedback_service_nonchromeos.cc
chrome/browser/extensions/api/identity/account_tracker.cc
chrome/browser/extensions/api/identity/gaia_web_auth_flow.cc
chrome/browser/extensions/api/identity/identity_api.cc
chrome/browser/extensions/api/identity/identity_apitest.cc
chrome/browser/extensions/api/identity/identity_signin_flow.cc
chrome/browser/extensions/api/push_messaging/push_messaging_api.cc
chrome/browser/extensions/api/webstore_private/webstore_private_api.cc
chrome/browser/extensions/browser_permissions_policy_delegate_unittest.cc
chrome/browser/extensions/token_cache/token_cache_service.cc
chrome/browser/first_run/first_run.cc
chrome/browser/history/web_history_service.cc
chrome/browser/invalidation/gcm_invalidation_bridge.cc
chrome/browser/invalidation/invalidation_service_factory.cc
chrome/browser/invalidation/ticl_invalidation_service_unittest.cc
chrome/browser/managed_mode/managed_user_registration_utility.cc
chrome/browser/managed_mode/managed_user_service.cc
chrome/browser/policy/cloud/cloud_policy_browsertest.cc
chrome/browser/policy/cloud/cloud_policy_manager_browsertest.cc
chrome/browser/policy/cloud/component_cloud_policy_browsertest.cc
chrome/browser/policy/cloud/user_policy_signin_service.cc
chrome/browser/policy/cloud/user_policy_signin_service_android.cc
chrome/browser/policy/cloud/user_policy_signin_service_base.cc
chrome/browser/policy/cloud/user_policy_signin_service_base.h
chrome/browser/policy/cloud/user_policy_signin_service_ios.mm
chrome/browser/policy/cloud/user_policy_signin_service_unittest.cc
chrome/browser/policy/policy_helpers.cc
chrome/browser/profiles/profile_downloader.cc
chrome/browser/services/gcm/gcm_profile_service.cc
chrome/browser/services/gcm/gcm_profile_service_unittest.cc
chrome/browser/signin/about_signin_internals.cc
chrome/browser/signin/about_signin_internals.h
chrome/browser/signin/account_reconcilor.h
chrome/browser/signin/account_reconcilor_unittest.cc
chrome/browser/signin/chrome_signin_client.cc
chrome/browser/signin/chrome_signin_client.h
chrome/browser/signin/fake_profile_oauth2_token_service.cc
chrome/browser/signin/fake_signin_manager.cc
chrome/browser/signin/fake_signin_manager.h
chrome/browser/signin/profile_oauth2_token_service_request.cc
chrome/browser/signin/signin_error_notifier_ash_unittest.cc
chrome/browser/signin/signin_global_error.cc
chrome/browser/signin/signin_global_error_unittest.cc
chrome/browser/signin/signin_manager_factory.cc
chrome/browser/signin/signin_manager_unittest.cc
chrome/browser/signin/signin_names_io_thread.cc
chrome/browser/signin/signin_names_io_thread_unittest.cc
chrome/browser/signin/signin_promo.cc
chrome/browser/signin/signin_tracker.cc
chrome/browser/signin/signin_tracker_unittest.cc
chrome/browser/signin/signin_ui_util.cc
chrome/browser/sync/about_sync_util.cc
chrome/browser/sync/profile_sync_components_factory_impl.cc
chrome/browser/sync/profile_sync_service.cc
chrome/browser/sync/profile_sync_service_android.cc
chrome/browser/sync/profile_sync_service_autofill_unittest.cc
chrome/browser/sync/profile_sync_service_factory.cc
chrome/browser/sync/profile_sync_service_mock.cc
chrome/browser/sync/profile_sync_service_preference_unittest.cc
chrome/browser/sync/profile_sync_service_session_unittest.cc
chrome/browser/sync/profile_sync_service_startup_unittest.cc
chrome/browser/sync/profile_sync_service_typed_url_unittest.cc
chrome/browser/sync/profile_sync_service_unittest.cc
chrome/browser/sync/sync_ui_util_unittest.cc
chrome/browser/sync/test/integration/sync_test.cc
chrome/browser/sync/test_profile_sync_service.cc
chrome/browser/sync_file_system/drive_backend/sync_engine.cc
chrome/browser/sync_file_system/drive_backend_v1/api_util.cc
chrome/browser/ui/app_list/app_list_view_delegate.cc
chrome/browser/ui/app_list/chrome_signin_delegate.cc
chrome/browser/ui/app_list/search/people/people_provider.cc
chrome/browser/ui/app_list/search/people/people_result.cc
chrome/browser/ui/app_list/test/chrome_app_list_test_support.cc
chrome/browser/ui/auto_login_infobar_delegate.h
chrome/browser/ui/auto_login_prompter.cc
chrome/browser/ui/chrome_pages.cc
chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller_unittest.mm
chrome/browser/ui/cocoa/browser/profile_chooser_controller.mm
chrome/browser/ui/cocoa/browser/profile_chooser_controller_unittest.mm
chrome/browser/ui/cocoa/browser_window_controller_unittest.mm
chrome/browser/ui/extensions/application_launch.cc
chrome/browser/ui/gtk/bookmarks/bookmark_bubble_gtk_browsertest.cc
chrome/browser/ui/search/search_tab_helper.cc
chrome/browser/ui/sync/one_click_signin_helper.cc
chrome/browser/ui/sync/one_click_signin_helper_unittest.cc
chrome/browser/ui/sync/one_click_signin_sync_starter.cc
chrome/browser/ui/sync/one_click_signin_sync_starter_unittest.cc
chrome/browser/ui/toolbar/wrench_menu_model.cc
chrome/browser/ui/views/avatar_menu_bubble_view.cc
chrome/browser/ui/views/bookmarks/bookmark_bubble_view_unittest.cc
chrome/browser/ui/views/profile_chooser_view.cc
chrome/browser/ui/webui/chromeos/login/inline_login_handler_chromeos.cc
chrome/browser/ui/webui/local_discovery/local_discovery_ui_browsertest.cc
chrome/browser/ui/webui/local_discovery/local_discovery_ui_handler.h
chrome/browser/ui/webui/ntp/android/promo_handler.cc
chrome/browser/ui/webui/ntp/new_tab_page_sync_handler.cc
chrome/browser/ui/webui/ntp/ntp_login_handler.cc
chrome/browser/ui/webui/options/browser_options_handler.cc
chrome/browser/ui/webui/options/manage_profile_handler.cc
chrome/browser/ui/webui/options/managed_user_create_confirm_handler.cc
chrome/browser/ui/webui/options/managed_user_import_handler.cc
chrome/browser/ui/webui/options/options_ui_browsertest.cc
chrome/browser/ui/webui/print_preview/print_preview_handler.cc
chrome/browser/ui/webui/signin/login_ui_service_factory.cc
chrome/browser/ui/webui/sync_setup_handler.cc
chrome/browser/ui/webui/sync_setup_handler_unittest.cc
chrome/chrome_browser.gypi
chrome/common/pref_names.cc
chrome/common/pref_names.h
chrome/test/base/chrome_render_view_host_test_harness.cc
components/signin.gypi
components/signin/core/browser/signin_account_id_helper.cc [moved from chrome/browser/signin/signin_account_id_helper.cc with 96% similarity]
components/signin/core/browser/signin_account_id_helper.h [moved from chrome/browser/signin/signin_account_id_helper.h with 84% similarity]
components/signin/core/browser/signin_client.h
components/signin/core/browser/signin_manager.cc [moved from chrome/browser/signin/signin_manager.cc with 88% similarity]
components/signin/core/browser/signin_manager.h [moved from chrome/browser/signin/signin_manager.h with 94% similarity]
components/signin/core/browser/signin_manager_base.cc
components/signin/core/browser/signin_manager_base.h
components/signin/core/browser/test_signin_client.cc
components/signin/core/browser/test_signin_client.h
components/signin/core/common/signin_pref_names.cc
components/signin/core/common/signin_pref_names.h