Revert 285173 "Removed InProcessBrowserTest::CleanUpOnMainThread()"
commit90f430f67ebd159d563823bf6d17555471eaa50a
authorasvitkine@chromium.org <asvitkine@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Thu, 24 Jul 2014 15:33:24 +0000 (24 15:33 +0000)
committerasvitkine@chromium.org <asvitkine@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Thu, 24 Jul 2014 15:33:24 +0000 (24 15:33 +0000)
tree665eaca463c6095943263f324d418b4bcb2e81d8
parent158b24d3b027d17067defef3836a33f3e2253bde
Revert 285173 "Removed InProcessBrowserTest::CleanUpOnMainThread()"

suspected to have broken ChromeOS browsertests:

SessionRestoreTestChromeOS.RestoreAppsV1
SessionRestoreTestChromeOS.RestoreBrowserWindows
SessionRestoreTestChromeOS.RestoreMaximized

Sample failure output:

SessionRestoreTestChromeOS.RestoreBrowserWindows (run #1):
[ RUN      ] SessionRestoreTestChromeOS.RestoreBrowserWindows
[7235:7235:0724/051700:WARNING:chrome_browser_main_chromeos.cc(275)] Running as stub user with profile dir: test-user
Xlib:  extension "RANDR" missing on display ":9".
[7235:7377:0724/051700:WARNING:local_extension_cache.cc(199)] Extensions will not be installed from update URLs until /var/cache/external_cache/.initialized exists.
../../chrome/browser/sessions/session_restore_browsertest_chromeos.cc:118: Failure
Value of: total_count
  Actual: 1
Expected: 2u
Which is: 2
[7235:7331:0724/051701:WARNING:raw_channel_posix.cc(214)] recvmsg: Connection reset by peer
[  FAILED  ] SessionRestoreTestChromeOS.RestoreBrowserWindows, where TypeParam =  and GetParam() =  (827 ms)

> Removed InProcessBrowserTest::CleanUpOnMainThread()
>
> Changed all instances of superfluous InProcessBrowserTest::CleanUpOnMainThread()
> API to use BrowserTestBase::TearDownOnMainThread() instead.
>
> BUG=381181
> TBR=rockot@chromium.org,sky@chromium.org,nkostylev@chromium.org
>
> Review URL: https://codereview.chromium.org/366813007

TBR=atwilson@chromium.org

Review URL: https://codereview.chromium.org/415133002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285278 0039d316-1c4b-4281-b951-d872f2087c98
90 files changed:
chrome/browser/apps/app_browsertest.cc
chrome/browser/apps/drive/drive_app_provider_browsertest.cc
chrome/browser/autofill/autofill_browsertest.cc
chrome/browser/autofill/autofill_interactive_uitest.cc
chrome/browser/captive_portal/captive_portal_browsertest.cc
chrome/browser/chromeos/accessibility/accessibility_manager_browsertest.cc
chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc
chrome/browser/chromeos/accessibility/touch_exploration_controller_browsertest.cc
chrome/browser/chromeos/customization_wallpaper_downloader_browsertest.cc
chrome/browser/chromeos/first_run/drive_first_run_browsertest.cc
chrome/browser/chromeos/login/existing_user_controller_browsertest.cc
chrome/browser/chromeos/login/kiosk_browsertest.cc
chrome/browser/chromeos/login/login_manager_test.cc
chrome/browser/chromeos/login/login_manager_test.h
chrome/browser/chromeos/login/oobe_browsertest.cc
chrome/browser/chromeos/login/saml/saml_browsertest.cc
chrome/browser/chromeos/login/screens/update_screen_browsertest.cc
chrome/browser/chromeos/login/supervised/supervised_user_test_base.cc
chrome/browser/chromeos/login/supervised/supervised_user_test_base.h
chrome/browser/chromeos/login/test/oobe_base_test.cc
chrome/browser/chromeos/login/test/oobe_base_test.h
chrome/browser/chromeos/login/test/wizard_in_process_browser_test.cc
chrome/browser/chromeos/login/test/wizard_in_process_browser_test.h
chrome/browser/chromeos/login/ui/captive_portal_window_browsertest.cc
chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager_browsertest.cc
chrome/browser/chromeos/policy/device_local_account_browsertest.cc
chrome/browser/chromeos/policy/login_screen_default_policy_browsertest.cc
chrome/browser/chromeos/policy/power_policy_browsertest.cc
chrome/browser/chromeos/power/peripheral_battery_observer_browsertest.cc
chrome/browser/chromeos/system/tray_accessibility_browsertest.cc
chrome/browser/devtools/device/usb/android_usb_browsertest.cc
chrome/browser/dom_distiller/dom_distiller_viewer_source_browsertest.cc
chrome/browser/download/download_browsertest.cc
chrome/browser/errorpage_browsertest.cc
chrome/browser/extensions/active_script_controller_browsertest.cc
chrome/browser/extensions/api/bluetooth/bluetooth_apitest.cc
chrome/browser/extensions/api/bluetooth/bluetooth_private_apitest.cc
chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_apitest.cc
chrome/browser/extensions/api/bluetooth_socket/bluetooth_socket_apitest.cc
chrome/browser/extensions/api/content_settings/content_settings_apitest.cc
chrome/browser/extensions/api/dns/dns_apitest.cc
chrome/browser/extensions/api/preference/preference_apitest.cc
chrome/browser/extensions/api/push_messaging/push_messaging_canary_test.cc
chrome/browser/extensions/api/socket/socket_apitest.cc
chrome/browser/extensions/api/sockets_tcp/sockets_tcp_apitest.cc
chrome/browser/extensions/api/sockets_tcp_server/sockets_tcp_server_apitest.cc
chrome/browser/extensions/api/sockets_udp/sockets_udp_apitest.cc
chrome/browser/extensions/api/streams_private/streams_private_apitest.cc
chrome/browser/extensions/api/system_display/system_display_apitest.cc
chrome/browser/extensions/extension_test_message_listener.h
chrome/browser/extensions/extension_toolbar_model_browsertest.cc
chrome/browser/net/dns_probe_browsertest.cc
chrome/browser/notifications/login_state_notification_blocker_chromeos_browsertest.cc
chrome/browser/password_manager/password_generation_interactive_uitest.cc
chrome/browser/password_manager/password_manager_browsertest.cc
chrome/browser/policy/cloud/cloud_policy_manager_browsertest.cc
chrome/browser/policy/cloud/device_management_service_browsertest.cc
chrome/browser/prefs/synced_pref_change_registrar_browsertest.cc
chrome/browser/printing/print_preview_dialog_controller_browsertest.cc
chrome/browser/renderer_context_menu/spelling_menu_observer_browsertest.cc
chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate_browsertest.cc
chrome/browser/resources/pdf/pdf_extension_test.cc
chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc
chrome/browser/search/suggestions/thumbnail_manager_browsertest.cc
chrome/browser/ssl/ssl_client_certificate_selector_test.cc
chrome/browser/ssl/ssl_client_certificate_selector_test.h
chrome/browser/sync/test/integration/sync_test.cc
chrome/browser/sync/test/integration/sync_test.h
chrome/browser/ui/app_list/search/people/people_provider_browsertest.cc
chrome/browser/ui/app_list/search/webstore/webstore_provider_browsertest.cc
chrome/browser/ui/browser_browsertest.cc
chrome/browser/ui/cocoa/location_bar/zoom_decoration_browsertest.mm
chrome/browser/ui/search/instant_extended_interactive_uitest.cc
chrome/browser/ui/search/instant_extended_manual_interactive_uitest.cc
chrome/browser/ui/tab_modal_confirm_dialog_browsertest.cc
chrome/browser/ui/tab_modal_confirm_dialog_browsertest.h
chrome/browser/ui/views/ash/tab_scrubber_browsertest.cc
chrome/browser/ui/views/message_center/web_notification_tray_browsertest.cc
chrome/browser/ui/views/ssl_client_certificate_selector_browsertest.cc
chrome/browser/ui/webui/bidi_checker_web_ui_test.cc
chrome/browser/ui/webui/bidi_checker_web_ui_test.h
chrome/browser/ui/webui/options/chromeos/accounts_options_browsertest.cc
chrome/browser/ui/webui/options/chromeos/shared_options_browsertest.cc
chrome/browser/ui/webui/signin/inline_login_ui_browsertest.cc
chrome/test/base/in_process_browser_test.cc
chrome/test/base/in_process_browser_test.h
chrome/test/base/test_chrome_web_ui_controller_factory_browsertest.cc
chrome/test/base/web_ui_browser_test.cc
chrome/test/base/web_ui_browser_test.h
extensions/browser/api/usb/usb_apitest.cc