| commit | 957d27bceb8155496e6f11fa1c22788de18e7d5d | |
| author | treib <treib@chromium.org> | |
| Wed, 15 Jul 2015 15:24:06 +0000 (15 08:24 -0700) | ||
| committer | Commit bot <commit-bot@chromium.org> | |
| Wed, 15 Jul 2015 15:25:41 +0000 (15 15:25 +0000) | ||
| tree | 7fe036133816a2da9e0fbedfc695437088bfa97b | treesnapshot (tar.gz zip) |
| parent | 2776ee378ee7d309d5d837e1e4405460403556ff | commitdiff |
ExtensionInstallDialogView: fix scrolling behavior on Views (Win,Linux)
Before:
Everything in the Views dialog (including title and icon) is in a ScrollView. This is different from the Cocoa version, in which only the content (permissions list etc) scrolls.
Also, the scrollbar overlaps the "close" button, see crbug.com/508040.
After:
Only the content scrolls. Title and icon are pulled out of the ScrollView.
Followup to https://codereview.chromium.org/1056003004
BUG=419403,508040
Review URL: https://codereview.chromium.org/1237483005
Cr-Commit-Position: refs/heads/master@{#338861}
Before:
Everything in the Views dialog (including title and icon) is in a ScrollView. This is different from the Cocoa version, in which only the content (permissions list etc) scrolls.
Also, the scrollbar overlaps the "close" button, see crbug.com/508040.
After:
Only the content scrolls. Title and icon are pulled out of the ScrollView.
Followup to https://codereview.chromium.org/1056003004
BUG=419403,508040
Review URL: https://codereview.chromium.org/1237483005
Cr-Commit-Position: refs/heads/master@{#338861}
| chrome/browser/ui/views/extensions/extension_install_dialog_view.cc | diffblobblamehistory | |
| chrome/browser/ui/views/extensions/extension_install_dialog_view.h | diffblobblamehistory |