| commit | 97206c26057c11573bf6aea8aff40ee345874648 | |
| author | primiano <primiano@chromium.org> | |
| Fri, 20 Feb 2015 14:31:12 +0000 (20 06:31 -0800) | ||
| committer | Commit bot <commit-bot@chromium.org> | |
| Fri, 20 Feb 2015 14:31:54 +0000 (20 14:31 +0000) | ||
| tree | 1fa3686e6ac450cb3e1551c061215f6f75d17239 | treesnapshot (tar.gz zip) |
| parent | 6b24b2094c9e3bc35e2c30b368f292e078d4a00b | commitdiff |
[tracing] Fix MemoryDumpManager testing instance teardown pattern.
crrev.com/933613002 introduced a ODR violtaion by adding the
DeleteForTesting method (other definition in trace_event_impl.cc).
This was causing an ASan assertion (see crbug.com/459556) and failures
of base_unittests in debug builds (see crrev.com/933613002 #33).
This CL fixes the DeleteForTesting pattern removing the awkward ODR
violation.
BUG=459556,458295
TBR=nduca@chromium.org
Review URL: https://codereview.chromium.org/942803002
Cr-Commit-Position: refs/heads/master@{#317316}
crrev.com/933613002 introduced a ODR violtaion by adding the
DeleteForTesting method (other definition in trace_event_impl.cc).
This was causing an ASan assertion (see crbug.com/459556) and failures
of base_unittests in debug builds (see crrev.com/933613002 #33).
This CL fixes the DeleteForTesting pattern removing the awkward ODR
violation.
BUG=459556,458295
TBR=nduca@chromium.org
Review URL: https://codereview.chromium.org/942803002
Cr-Commit-Position: refs/heads/master@{#317316}
| base/trace_event/memory_dump_manager.cc | diffblobblamehistory | |
| base/trace_event/memory_dump_manager.h | diffblobblamehistory | |
| base/trace_event/memory_dump_manager_unittest.cc | diffblobblamehistory |