| commit | 989e40a23b3744a5edf236c6391f4f5e35e90c51 | |
| author | pkl <pkl@chromium.org> | |
| Wed, 19 Aug 2015 17:06:36 +0000 (19 10:06 -0700) | ||
| committer | Commit bot <commit-bot@chromium.org> | |
| Wed, 19 Aug 2015 17:07:12 +0000 (19 17:07 +0000) | ||
| tree | ae446e833d7c45555583e3b2482c9a02ea38a31c | treesnapshot (tar.gz zip) |
| parent | 6157847acc21ce6f1da2ca25d70037f1f07dc35b | commitdiff |
Notifications were never unregistered during unit tests.
Unit tests failure (DCHECK) due to objects over-retained by debug-only
consistency checks. The performSelector:withObject:afterDelay: retains
the object for at least 60 seconds causing object to live long enough
to catch the notification from a different test and thus DCHECK.
The failure is flaky because it is dependent on the order of
notification delivery.
The fix here is to disable consistency checks completely during unit
tests. Consistency checks are enabled in MainController which is not
part of this unit test.
BUG=518162
Review URL: https://codereview.chromium.org/1298223003
Cr-Commit-Position: refs/heads/master@{#344258}
Unit tests failure (DCHECK) due to objects over-retained by debug-only
consistency checks. The performSelector:withObject:afterDelay: retains
the object for at least 60 seconds causing object to live long enough
to catch the notification from a different test and thus DCHECK.
The failure is flaky because it is dependent on the order of
notification delivery.
The fix here is to disable consistency checks completely during unit
tests. Consistency checks are enabled in MainController which is not
part of this unit test.
BUG=518162
Review URL: https://codereview.chromium.org/1298223003
Cr-Commit-Position: refs/heads/master@{#344258}
| ios/chrome/browser/updatable_config/updatable_config_base.mm | diffblobblamehistory |