Enable the views-based AppInfoDialog on Mac
commit99e8dd40da33d58d598b000e122939b04272c079
authortapted <tapted@chromium.org>
Tue, 12 May 2015 06:22:47 +0000 (11 23:22 -0700)
committerCommit bot <commit-bot@chromium.org>
Tue, 12 May 2015 06:23:03 +0000 (12 06:23 +0000)
treeb03b871ec2fac29b5c9be534ecf54d8f5712b56c
parentf46f86c6c0b32fdc98b7c27ace907de67d735fe8
Enable the views-based AppInfoDialog on Mac

There's an expected ~443kB sizes regression in ChromiumFramework with
this. This is because large portions of views.dylib are still culled at
link time with -dead_strip, but this CL makes more symbols reachable.
For a full accounting see http://crbug.com/485854#c1 (nothing
unexpected).

The dialog is enabled by linking in app_info_dialog_views.cc to provide
functions previously provided (but NOTIMPLEMENTED()) by
app_info_dialog_cocoa.mm.

Note that the views CanShowAppInfoDialog() is implemented as
IsMacViewsAppListListEnabled(), so no user-visible changes occur unless
Chrome is run from the command line with --enable-mac-views-app-list.

With this flag, the `Details` link at chrome://extensions will show the
views-based (and offline-enabled) AppInfo dialog rather than taking the
user to the webstore URL. And the context menu for icons at
chrome://apps will have an `App Info` option.

(Note that the views-based App Launcher isn't currently linked in on
Mac, so the app launcher shown with --enable-mac-views-app-list
--show-app-list doesn't support this dialog yet).

Screenshot at http://crbug.com/485854#c2

BUG=485854

Review URL: https://codereview.chromium.org/1048343002

Cr-Commit-Position: refs/heads/master@{#329362}
chrome/browser/ui/cocoa/apps/app_info_dialog_cocoa.mm [deleted file]
chrome/chrome_browser_ui.gypi