| commit | 9a76dd0553dc4cd17386065bd18506b49751e807 | |
| author | mcgrathr@chromium.org <mcgrathr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Thu, 15 Dec 2011 00:27:54 +0000 (15 00:27 +0000) | ||
| committer | mcgrathr@chromium.org <mcgrathr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Thu, 15 Dec 2011 00:27:54 +0000 (15 00:27 +0000) | ||
| tree | 980f4c04ef6d1e1c1e2ffbc44f41dba9ec264c82 | treesnapshot (tar.gz zip) |
| parent | cd8e55252e2516c70c3c013ee83fb2a17a92d38c | commitdiff |
Revert 114539 - Move content::MakeSharedMemorySegmentViaIPC into its own file
The nacl_helper program uses content::MakeSharedMemorySegmentViaIPC but
none of the other proxy functions in the same source file. Some of those
functions refer to symbols that bring in a great deal of other code, e.g.
most of v8. We don't want all that code linked into nacl_helper--it bloats
the binary by a factor of ten or so.
Moving the function out to its own file prevents the other dependencies
coming in unnecessarily.
BUG= http://code.google.com/p/chromium/issues/detail?id=106986
TEST= still builds and nacl_helper binary is much smaller
R=jam@chromium.org,bradchen@google.com
Review URL: http://codereview.chromium.org/8893009
TBR=mcgrathr@chromium.org
Review URL: http://codereview.chromium.org/8914026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114542 0039d316-1c4b-4281-b951-d872f2087c98
The nacl_helper program uses content::MakeSharedMemorySegmentViaIPC but
none of the other proxy functions in the same source file. Some of those
functions refer to symbols that bring in a great deal of other code, e.g.
most of v8. We don't want all that code linked into nacl_helper--it bloats
the binary by a factor of ten or so.
Moving the function out to its own file prevents the other dependencies
coming in unnecessarily.
BUG= http://code.google.com/p/chromium/issues/detail?id=106986
TEST= still builds and nacl_helper binary is much smaller
R=jam@chromium.org,bradchen@google.com
Review URL: http://codereview.chromium.org/8893009
TBR=mcgrathr@chromium.org
Review URL: http://codereview.chromium.org/8914026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114542 0039d316-1c4b-4281-b951-d872f2087c98