[safe-browsing] Mechanical cleanups to tests and naming.
commit9d349ce7913ab3a2cb79e9277a86d6e529bcf20f
authorshess@chromium.org <shess@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Wed, 14 May 2014 05:28:52 +0000 (14 05:28 +0000)
committershess@chromium.org <shess@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Wed, 14 May 2014 05:28:52 +0000 (14 05:28 +0000)
tree18408e540b6bcdf05aac337377b13936a3a715cb
parent4016ebc557bc508d273366d706bd4ffd98692579
[safe-browsing] Mechanical cleanups to tests and naming.

Pull out and extend a bunch of mechanical changes from:
  https://codereview.chromium.org/220493003/
in hopes that the actual functional changes will be cleaner.

This includes:
 - cached_hits -> cache_hits
 - cached_hashes -> cache_hits
 - ASSERT_TRUE(UpdateStarted()) in db tests.
 - *_EQ() has expected value on the left in db tests.
 - ASSERT to check container sizes before dereferencing in db tests.
 - Compare list names as strings in db tests.
 - Consistently use prefix_hits for prefix hits in db tests.
 - Check prefix_hits before cache_hits in db tests.
 - Remove unused cache-related code from browser test.

BUG=357763

Review URL: https://codereview.chromium.org/283873002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270335 0039d316-1c4b-4281-b951-d872f2087c98
chrome/browser/safe_browsing/database_manager.cc
chrome/browser/safe_browsing/database_manager.h
chrome/browser/safe_browsing/safe_browsing_database.cc
chrome/browser/safe_browsing/safe_browsing_database.h
chrome/browser/safe_browsing/safe_browsing_database_unittest.cc
chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc