| commit | a25c24fc722cf162ab92408670e7d47b8c3e6994 | |
| author | mmenke <mmenke@chromium.org> | |
| Tue, 4 Aug 2015 20:38:54 +0000 (4 13:38 -0700) | ||
| committer | Commit bot <commit-bot@chromium.org> | |
| Tue, 4 Aug 2015 20:43:55 +0000 (4 20:43 +0000) | ||
| tree | ede30b3dae574c4123948844f706c25b14efb2c7 | treesnapshot (tar.gz zip) |
| parent | 93102bcfca81af17e97fcad1c28b027fa7cad114 | commitdiff |
Fix case where ErrorPageController outlives the frame it's attached to.
ErrorPageController could call into NetErrorHelper after the page it's
attached to was destroyed. This CL gives the controller a weak pointer
to the NetErrorHelper that's invalidated on commit, which should fix
the issue.
BUG=500556
Review URL: https://codereview.chromium.org/1259653003
Cr-Commit-Position: refs/heads/master@{#341785}
ErrorPageController could call into NetErrorHelper after the page it's
attached to was destroyed. This CL gives the controller a weak pointer
to the NetErrorHelper that's invalidated on commit, which should fix
the issue.
BUG=500556
Review URL: https://codereview.chromium.org/1259653003
Cr-Commit-Position: refs/heads/master@{#341785}