| commit | a30ca3cd77a8a33b839c59973c414692b19f872b | |
| author | v.putkinen <v.putkinen@partner.samsung.com> | |
| Mon, 20 Oct 2014 22:04:19 +0000 (20 15:04 -0700) | ||
| committer | Commit bot <commit-bot@chromium.org> | |
| Mon, 20 Oct 2014 22:05:21 +0000 (20 22:05 +0000) | ||
| tree | 44e58e6a2bbe3f57b6240f945015ecda3c76cb84 | treesnapshot (tar.gz zip) |
| parent | 078d21029b8c7628d40dd9c98ca839f017ae1647 | commitdiff |
[Telemetry] Fix C-State stat reading for Note 3 and S5.
On some Android devices, the sysfs-based C-State info contains extra blank
lines which will cause an exception in C-State stat parser in Android platform
backend if the power metric and a Monsoon Power Monitor is in use. More
precisely, /sys/devices/system/cpu/cpu*/cpuidle/state*/name contains two
trailing newlines on at least Samsung Galaxy Note 3 and S5.
This patch filters out these blank lines from the sysfs output and fixes nearby
style.
BUG=421008
TEST=SysfsPowerMonitorMonitorTest.testGetCpuStateForAndroidDevices
Review URL: https://codereview.chromium.org/635313002
Cr-Commit-Position: refs/heads/master@{#300347}
On some Android devices, the sysfs-based C-State info contains extra blank
lines which will cause an exception in C-State stat parser in Android platform
backend if the power metric and a Monsoon Power Monitor is in use. More
precisely, /sys/devices/system/cpu/cpu*/cpuidle/state*/name contains two
trailing newlines on at least Samsung Galaxy Note 3 and S5.
This patch filters out these blank lines from the sysfs output and fixes nearby
style.
BUG=421008
TEST=SysfsPowerMonitorMonitorTest.testGetCpuStateForAndroidDevices
Review URL: https://codereview.chromium.org/635313002
Cr-Commit-Position: refs/heads/master@{#300347}