Refactor WebsiteSettings to operate on a SecurityInfo
commita3121f6b5613d73812729c8197f3dd7877fbefbe
authorestark <estark@chromium.org>
Fri, 18 Sep 2015 21:15:59 +0000 (18 14:15 -0700)
committerCommit bot <commit-bot@chromium.org>
Fri, 18 Sep 2015 21:16:37 +0000 (18 21:16 +0000)
treedc8ba691e8fb83d62ab06f9ef90aa8407ff8d37a
parentfda25c9686e6f189dff8beae9914fc8426442c5f
Refactor WebsiteSettings to operate on a SecurityInfo

Previously, WebsiteSettings operated on a content::SSLStatus. This gave
us no convenient place to share policies and calculations that
WebsiteSettings shared with other //chrome security UI elements: for
example, SHA1 deprecation and ChromeOS policy certs.

This CL refactors WebsiteSettings to operate on a
SecurityStateModel::SecurityInfo instead of a content::SSLStatus. The
SecurityInfo object already contains information about, for example,
SHA1 deprecation, so that WebsiteSettings doesn't have to compute that
on its own.

BUG=528034

Review URL: https://codereview.chromium.org/1314953009

Cr-Commit-Position: refs/heads/master@{#349772}
29 files changed:
chrome/browser/chromeos/login/ui/simple_web_view_dialog.cc
chrome/browser/chromeos/login/ui/simple_web_view_dialog.h
chrome/browser/renderer_context_menu/render_view_context_menu.cc
chrome/browser/ui/android/connection_info_popup_android.cc
chrome/browser/ui/android/website_settings_popup_android.cc
chrome/browser/ui/browser_commands.cc
chrome/browser/ui/browser_commands.h
chrome/browser/ui/browser_dialogs.h
chrome/browser/ui/browser_window.h
chrome/browser/ui/cocoa/browser_window_cocoa.h
chrome/browser/ui/cocoa/browser_window_cocoa.mm
chrome/browser/ui/cocoa/location_bar/location_icon_decoration.mm
chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.h
chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.mm
chrome/browser/ui/views/browser_dialogs_views_mac.cc
chrome/browser/ui/views/frame/browser_view.cc
chrome/browser/ui/views/frame/browser_view.h
chrome/browser/ui/views/frame/web_app_left_header_view_ash.cc
chrome/browser/ui/views/location_bar/location_bar_view.h
chrome/browser/ui/views/location_bar/page_info_helper.cc
chrome/browser/ui/views/toolbar/toolbar_view.cc
chrome/browser/ui/views/toolbar/toolbar_view.h
chrome/browser/ui/views/website_settings/website_settings_popup_view.cc
chrome/browser/ui/views/website_settings/website_settings_popup_view.h
chrome/browser/ui/views/website_settings/website_settings_popup_view_unittest.cc
chrome/browser/ui/website_settings/website_settings.cc
chrome/browser/ui/website_settings/website_settings.h
chrome/browser/ui/website_settings/website_settings_unittest.cc
chrome/test/base/test_browser_window.h