| commit | b24a3b7041f8f269483afa6e9708562b32667fd3 | |
| author | dfalcantara <dfalcantara@chromium.org> | |
| Sat, 11 Jul 2015 00:38:15 +0000 (10 17:38 -0700) | ||
| committer | Commit bot <commit-bot@chromium.org> | |
| Sat, 11 Jul 2015 00:38:49 +0000 (11 00:38 +0000) | ||
| tree | 9435e1751d5e13fa4849a3c7ecbdabd95c2e0ecf | treesnapshot (tar.gz zip) |
| parent | 5fd713ee7244a4949e120c9ababdb71fda3109f5 | commitdiff |
Standardize parameters passed when Tabs are created asynchronously.
* Pulls out PendingDocumentData from the DocumentTabModelSelector and makes
it a standalone thing. The new AsyncTabCreationParamsManager acts as the
DocumentTabModelSelector did and stores a mapping of Tab IDs to pending
data, which are now stored in AsyncTabCreationParams.
* Callsites are all changed to use the new AsyncTabCreationParams instead.
* AsyncTabCreationParams now stores a LoadUrlParams instead of random fields
from the LoadUrlParams.
* Fields in the AsyncTabCreationParams are clearly marked exclusive, based
on how they are constructed.
BUG=508333
Review URL: https://codereview.chromium.org/1235523003
Cr-Commit-Position: refs/heads/master@{#338411}
* Pulls out PendingDocumentData from the DocumentTabModelSelector and makes
it a standalone thing. The new AsyncTabCreationParamsManager acts as the
DocumentTabModelSelector did and stores a mapping of Tab IDs to pending
data, which are now stored in AsyncTabCreationParams.
* Callsites are all changed to use the new AsyncTabCreationParams instead.
* AsyncTabCreationParams now stores a LoadUrlParams instead of random fields
from the LoadUrlParams.
* Fields in the AsyncTabCreationParams are clearly marked exclusive, based
on how they are constructed.
BUG=508333
Review URL: https://codereview.chromium.org/1235523003
Cr-Commit-Position: refs/heads/master@{#338411}
12 files changed: