Simplify permission-related code for Web Notifications.
commitb514ab0de3c448941a4b3d16d5984b042e3d51c0
authorpeter <peter@chromium.org>
Thu, 2 Jul 2015 12:10:51 +0000 (2 05:10 -0700)
committerCommit bot <commit-bot@chromium.org>
Thu, 2 Jul 2015 12:11:29 +0000 (2 12:11 +0000)
tree14f118b1b98f21a66be5109e818b85e59fd0b5da
parent56116f4d5ff944b3f942fbb451911f78d8f8b0af
Simplify permission-related code for Web Notifications.

  (1) Remove support for inheriting the "notification" API permission
      for packaged and hosted apps using the Web Notification API. This
      has been inadvertently broken since Chrome 42.

  (2) Give notifications a dedicated NotificationPermissionContext,
      similar to those other features have. (+ unit tests)

  (3) Remove and clean up all unused code.

This further emphasizes the DesktopNotificationService as a deprecated
concept. I'll remove it entirely in a follow-up patch.

BUG=504361

Review URL: https://codereview.chromium.org/1207363002

Cr-Commit-Position: refs/heads/master@{#337206}
15 files changed:
chrome/browser/notifications/desktop_notification_service.cc
chrome/browser/notifications/desktop_notification_service.h
chrome/browser/notifications/notification_permission_context.cc [new file with mode: 0644]
chrome/browser/notifications/notification_permission_context.h [new file with mode: 0644]
chrome/browser/notifications/notification_permission_context_factory.cc [new file with mode: 0644]
chrome/browser/notifications/notification_permission_context_factory.h [new file with mode: 0644]
chrome/browser/notifications/notification_permission_context_unittest.cc [new file with mode: 0644]
chrome/browser/notifications/platform_notification_service_impl.cc
chrome/browser/permissions/permission_context.cc
chrome/browser/push_messaging/push_messaging_permission_context.cc
chrome/chrome_browser.gypi
chrome/chrome_tests_unit.gypi
extensions/browser/info_map.cc
extensions/browser/info_map.h
tools/metrics/histograms/histograms.xml