| commit | b699280919e2361cdbc2028a97f864cb2612df1c | |
| author | skuhne@google.com <skuhne@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Fri, 20 Sep 2013 23:09:19 +0000 (20 23:09 +0000) | ||
| committer | skuhne@google.com <skuhne@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Fri, 20 Sep 2013 23:09:19 +0000 (20 23:09 +0000) | ||
| tree | cf7c964e4ece08ae908ebc6f0465cbaf39fa3665 | treesnapshot (tar.gz zip) |
| parent | 921ce4137eee637c727d6dd9c5bf23e5c203e95c | commitdiff |
Fixed problems with pin/unpin preferences changing for not running applications & icon order changes upon sync operations
There are multiple problems fixed with this patch:
1. When a running and pinned app (Windowed V1, V2) gets unpinned via sync operation (or multi user switching), the icon will disappear and the sytem gets into an unstable state (-> Crash later on).
2. When a running app (Windowed V1, V2) gets pinned via a sync operation (or multi user switching), the icon will be shown, but get into an unsecure state which can lead to crashes.
3. There are several cases, where the chrome browser icon does change locations due to sync / multi user switching operations. In this case the icon can shift by one spot to the right.
4. There were some problems with the alternate shelf layout.
That all said: With M32 we should possibly come up with a new way of storing running V1/V2 applications since the running applications are not stored by the preferences and can therefore flip around when switching between users AND windowed V1 apps currently have the same "weight" as an application launcher - which means that they will "float around" in the shelf between sync / switch operations.
My visual test to see that everything was working was as follows:
In Multi session mode, have one user with the following applications pinned:
Chrome Shop, VNC, Angry Birds, gmail, calendar, chrome
and another user with two other applications and chrome.
Switch between the two and everything should be fine.
Run VNC (V2 app). Switch to user 2 and see that it is unpinned at the end of the list. Switch back and see it sliding back to where it belongs.
Then do the same for a windowed V1 app (gmail). Note that the gmail item will not float to the end of the list in user 2 - which is because of the already mentioned weights.
BUG=294435, 294231, 294227
TEST=unit tests and visual (see above)
R=oshima@chromium.org
Review URL: https://codereview.chromium.org/23580008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224514 0039d316-1c4b-4281-b951-d872f2087c98
There are multiple problems fixed with this patch:
1. When a running and pinned app (Windowed V1, V2) gets unpinned via sync operation (or multi user switching), the icon will disappear and the sytem gets into an unstable state (-> Crash later on).
2. When a running app (Windowed V1, V2) gets pinned via a sync operation (or multi user switching), the icon will be shown, but get into an unsecure state which can lead to crashes.
3. There are several cases, where the chrome browser icon does change locations due to sync / multi user switching operations. In this case the icon can shift by one spot to the right.
4. There were some problems with the alternate shelf layout.
That all said: With M32 we should possibly come up with a new way of storing running V1/V2 applications since the running applications are not stored by the preferences and can therefore flip around when switching between users AND windowed V1 apps currently have the same "weight" as an application launcher - which means that they will "float around" in the shelf between sync / switch operations.
My visual test to see that everything was working was as follows:
In Multi session mode, have one user with the following applications pinned:
Chrome Shop, VNC, Angry Birds, gmail, calendar, chrome
and another user with two other applications and chrome.
Switch between the two and everything should be fine.
Run VNC (V2 app). Switch to user 2 and see that it is unpinned at the end of the list. Switch back and see it sliding back to where it belongs.
Then do the same for a windowed V1 app (gmail). Note that the gmail item will not float to the end of the list in user 2 - which is because of the already mentioned weights.
BUG=294435, 294231, 294227
TEST=unit tests and visual (see above)
R=oshima@chromium.org
Review URL: https://codereview.chromium.org/23580008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224514 0039d316-1c4b-4281-b951-d872f2087c98