| commit | bcebf95362c4def943d996dbc5c57f67d7bd03a5 | |
| author | skuhne@chromium.org <skuhne@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Thu, 13 Feb 2014 00:56:34 +0000 (13 00:56 +0000) | ||
| committer | skuhne@chromium.org <skuhne@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Thu, 13 Feb 2014 00:56:34 +0000 (13 00:56 +0000) | ||
| tree | d1de97ddb949ee8af5afdc4fb62f6337560db3c4 | treesnapshot (tar.gz zip) |
| parent | 949f62a306e04551f02cdc9d49cfc95d0e9c3f54 | commitdiff |
Fixing M33 and M34 stable blocker crash with InsertAppLauncherItem
The problem appears to be that the function GetLastActiveWebContents returns a WebContents pointer to some content which got already deleted. (See comment from CL).
Note that this is only used in InsertAppLauncherItem to find the activity state. Note that this indicates that we could even get rid of that map and use app_id_to_web_contents to find if a tab is currently active. But again - keeping the CL small for the backport.
This seems to be the most secure and isolated for for M33 and 34 - I will create an issue to follow up on this the proper way.
BUG=341250
TEST=none (no test case known)
Review URL: https://codereview.chromium.org/160803002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250874 0039d316-1c4b-4281-b951-d872f2087c98
The problem appears to be that the function GetLastActiveWebContents returns a WebContents pointer to some content which got already deleted. (See comment from CL).
Note that this is only used in InsertAppLauncherItem to find the activity state. Note that this indicates that we could even get rid of that map and use app_id_to_web_contents to find if a tab is currently active. But again - keeping the CL small for the backport.
This seems to be the most secure and isolated for for M33 and 34 - I will create an issue to follow up on this the proper way.
BUG=341250
TEST=none (no test case known)
Review URL: https://codereview.chromium.org/160803002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250874 0039d316-1c4b-4281-b951-d872f2087c98
| chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc | diffblobblamehistory |