Revert of [KeyEvent Mac] Move WebInputEventFactory into chromium. (patchset #7 id...
commitbd8d56bb5c281d4b3ca5306dff59294108329c08
authorkochi <kochi@chromium.org>
Wed, 16 Sep 2015 01:19:19 +0000 (15 18:19 -0700)
committerCommit bot <commit-bot@chromium.org>
Wed, 16 Sep 2015 01:19:50 +0000 (16 01:19 +0000)
tree75b15e6522830cd735e4079520a01dda10c4bdbe
parent35ecf40fb75893838295418d07fa5d37bcca10d7
Revert of [KeyEvent Mac] Move WebInputEventFactory into chromium. (patchset #7 id:120001 of https://codereview.chromium.org/1331013004/ )

Reason for revert:
This caused compile failure on MacOSX 10.9 Retina
bot.

The relevant error log:

../../content/browser/renderer_host/input/web_input_event_builders_mac.mm:889:10: error: use of undeclared identifier 'NSEventTypeSmartMagnify'; did you mean 'NSEventTypeMagnify'?
    case NSEventTypeSmartMagnify:
         ^~~~~~~~~~~~~~~~~~~~~~~
         NSEventTypeMagnify
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.6.sdk/System/Library/Frameworks/AppKit.framework/Headers/NSEvent.h:48:5: note: 'NSEventTypeMagnify' declared here
    NSEventTypeMagnify          = 30,
    ^
../../content/browser/renderer_host/input/web_input_event_builders_mac.mm:889:10: error: duplicate case value 'NSEventTypeMagnify'
    case NSEventTypeSmartMagnify:
         ^
../../content/browser/renderer_host/input/web_input_event_builders_mac.mm:885:10: note: previous case defined here
    case NSEventTypeMagnify:
         ^
2 errors generated.
ninja: build stopped: subcommand failed.

Original issue's description:
> [KeyEvent Mac] Move WebInputEventFactory into chromium.
>
> There was an inconsistency on the Mac platform that the WebInputEventFactory
> (old WebKit code) was being used. Other platforms have migrated to using
> builders and it was weird for the Mac code path to have some code on one
> side of the blink divide that others didn't. This change brings the Mac
> platform inline with the others by moving the input event
> factory from blink into chromium.
>
> blink change: https://codereview.chromium.org/1335673002/
>
> BUG=493833,237267
>
> Committed: https://crrev.com/8db5ca887d4560ed15bf5e6e2dce69dc85868f25
> Cr-Commit-Position: refs/heads/master@{#348989}

TBR=wez@chromium.org,sadrul@chromium.org,asvitkine@chromium.org,mnaganov@chromium.org,piman@chromium.org,dtapuska@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=493833,237267

Review URL: https://codereview.chromium.org/1345043003

Cr-Commit-Position: refs/heads/master@{#349058}
14 files changed:
content/browser/DEPS
content/browser/renderer_host/input/web_input_event_builders_mac.h [deleted file]
content/browser/renderer_host/input/web_input_event_builders_mac.mm [deleted file]
content/browser/renderer_host/input/web_input_event_builders_mac_unittest.mm [deleted file]
content/browser/renderer_host/input/web_input_event_util.cc
content/browser/renderer_host/input/web_input_event_util.h
content/browser/renderer_host/native_web_keyboard_event_mac.mm
content/browser/renderer_host/render_widget_host_view_mac.mm
content/browser/renderer_host/web_input_event_aura.cc
content/content_browser.gypi
content/content_tests.gypi
tools/copyright_scanner/third_party_files_whitelist.txt
ui/events/cocoa/events_mac.mm
ui/events/keycodes/keyboard_code_conversion_mac.h