Revert of Revert of [Mac] Do not let apps keep Chrome alive if shutting down. (patchs...
commitbf942015e5d76e81d83b2bc3e5f749962910262c
authorjochen <jochen@chromium.org>
Tue, 13 Jan 2015 14:12:57 +0000 (13 06:12 -0800)
committerCommit bot <commit-bot@chromium.org>
Tue, 13 Jan 2015 14:13:53 +0000 (13 14:13 +0000)
tree709de749ed3a10f50c6715e2e17eebe4070a7732
parentb71618f4c03564ae65efde061c06ca25015912f3
Revert of Revert of [Mac] Do not let apps keep Chrome alive if shutting down. (patchset #1 id:1 of https://codereview.chromium.org/821483004/)

Reason for revert:
didn't help... relanding

Original issue's description:
> Revert of [Mac] Do not let apps keep Chrome alive if shutting down. (patchset #6 id:100001 of https://codereview.chromium.org/831813003/)
>
> Reason for revert:
> speculative revert to see whether this broke BrowserTabRestoreTest.RecentTabsMenuTabDisposition on mac dbg
>
> Original issue's description:
> > [Mac] Do not let apps keep Chrome alive if shutting down.
> >
> > If the user quits Chrome while Chrome Apps are running, we keep Chrome running
> > in the background and show a notification.
> >
> > When Chrome is terminated because the system is shutting down or the user is
> > logging off, we should make sure Chrome terminates regardless of any running apps.
> >
> > This CL detects whether an [NSApplication terminate:] is due to shutdown or log off
> > by listening for NSWorkspaceWillPowerOffNotification. This notification is only
> > received if Chrome is about to be terminated, i.e. we do not receive the notification
> > if another app prevented shutdown.
> >
> > BUG=442280
> >
> > Committed: https://crrev.com/f60ef51534ed50361020392ed74435cfa7d6e311
> > Cr-Commit-Position: refs/heads/master@{#311215}
>
> TBR=tapted@chromium.org,rsesek@chromium.org,jackhou@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=442280
>
> Committed: https://crrev.com/494f1ea5e8cb9dea6b78cfb812e4e6a5841ab9b6
> Cr-Commit-Position: refs/heads/master@{#311246}

TBR=tapted@chromium.org,rsesek@chromium.org,jackhou@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=442280

Review URL: https://codereview.chromium.org/851713002

Cr-Commit-Position: refs/heads/master@{#311265}
chrome/browser/app_controller_mac.h
chrome/browser/app_controller_mac.mm
chrome/browser/ui/cocoa/apps/quit_with_apps_controller_mac_interactive_uitest.mm [moved from chrome/browser/ui/cocoa/apps/quit_with_apps_controller_mac_interactive_uitest.cc with 83% similarity]
chrome/chrome_tests.gypi