Revert of Do not create proxy hosts in the subtree of navigating frame. (patchset...
commitc328fa4adbb3dc43b921d643ac0cf73fea5c42ef
authorengedy <engedy@chromium.org>
Fri, 12 Sep 2014 08:56:08 +0000 (12 01:56 -0700)
committerCommit bot <commit-bot@chromium.org>
Fri, 12 Sep 2014 08:58:44 +0000 (12 08:58 +0000)
tree4bec1de38ac3345765baa96fb5aa76dcd1f0b3e3
parentef20600e0dd7b45483a8e5264df36304a8ecef5d
Revert of Do not create proxy hosts in the subtree of navigating frame. (patchset #11 id:200001 of https://codereview.chromium.org/536143002/)

Reason for revert:
SitePerProcessBrowserTest.ProxyCreationSkipsSubtree repeatedly fails on Mac with ASAN reporting use-after-free, see:

http://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Tests%20%281%29/builds/2174
http://build.chromium.org/p/chromium.fyi/builders/Chromium%20Mac%2010.8%20Buildrunner/builds/19009

@Nasko, as there are some simultaneous breakages right now, so I could not investigate this further and opted to revert the whole thing to get the tree green ASAP.

Snippets from test log:

ASSERTION FAILED: !localFrame || (localFrame->isLocalFrame())
../../third_party/WebKit/Source/core/frame/LocalFrame.h(253) : blink::LocalFrame *blink::toLocalFrame(blink::Frame *)
../../content/browser/site_per_process_browsertest.cc:690: Failure
Value of: child->child_count()
  Actual: 2
Expected: 0U
Which is: 0

Original issue's description:
> Do not create proxy hosts in the subtree of navigating frame.
>
> When a frame is navigating cross-process, its existing document will be completely destroyed and all child frames will be gone. This means that we don't need to create proxy objects for the new SiteInstance in the subtree of the navigating frame.
>
> BUG=357747
>
> Committed: https://crrev.com/faab4288197b20b73610aad3e5579751b0c3a97b
> Cr-Commit-Position: refs/heads/master@{#294520}

TBR=ajwong@chromium.org,kenrb@chromium.org,jam@chromium.org,creis@chromium.org,dmazzoni@chromium.org,nasko@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=357747

Review URL: https://codereview.chromium.org/565103002

Cr-Commit-Position: refs/heads/master@{#294552}
content/browser/accessibility/site_per_process_accessibility_browsertest.cc
content/browser/frame_host/frame_tree.cc
content/browser/frame_host/frame_tree.h
content/browser/frame_host/frame_tree_browsertest.cc
content/browser/frame_host/render_frame_host_manager.cc
content/browser/site_per_process_browsertest.cc
content/test/data/site_per_process_main.html