| commit | c3ef01071c3a6c2b0550a016d0ad901689ffe947 | |
| author | jdduke <jdduke@chromium.org> | |
| Thu, 7 May 2015 21:00:38 +0000 (7 14:00 -0700) | ||
| committer | Commit bot <commit-bot@chromium.org> | |
| Thu, 7 May 2015 21:01:08 +0000 (7 21:01 +0000) | ||
| tree | 67db1945c429971afe68361de6d37b6cda1e19cc | treesnapshot (tar.gz zip) |
| parent | 03619407b9ec7b47b0d96e265f2574dc8b369b1c | commitdiff |
[Android] Dismiss refresh spinner when showing the repost warn dialog
If the user cancels a refresh via the report form warning dialog, we
never get a callback that the page has been reloaded. Consequently,
for gesture-triggered reloads the refresh spinner would continue showing
after the reload cancellation.
Instead, simply cancel the refresh animation when the repost warning
dialog is shown. This avoids any associated callback guarantee issues
while also preventing animation jank as the dialog is shown.
Also set the MaterialProgressDrawable animation's repeat count back to
infinite, instead relying on the SwipeRefreshHandler container to
terminate the refresh animation after a reasonable upper limit.
BUG=485609
Review URL: https://codereview.chromium.org/1131903003
Cr-Commit-Position: refs/heads/master@{#328825}
If the user cancels a refresh via the report form warning dialog, we
never get a callback that the page has been reloaded. Consequently,
for gesture-triggered reloads the refresh spinner would continue showing
after the reload cancellation.
Instead, simply cancel the refresh animation when the repost warning
dialog is shown. This avoids any associated callback guarantee issues
while also preventing animation jank as the dialog is shown.
Also set the MaterialProgressDrawable animation's repeat count back to
infinite, instead relying on the SwipeRefreshHandler container to
terminate the refresh animation after a reasonable upper limit.
BUG=485609
Review URL: https://codereview.chromium.org/1131903003
Cr-Commit-Position: refs/heads/master@{#328825}