| commit | cd74d5568a25c0a50ca8275b88a8d37bc066d275 | |
| author | lionel.g.landwerlin <lionel.g.landwerlin@intel.com> | |
| Tue, 30 Jun 2015 19:24:23 +0000 (30 12:24 -0700) | ||
| committer | Commit bot <commit-bot@chromium.org> | |
| Tue, 30 Jun 2015 19:26:10 +0000 (30 19:26 +0000) | ||
| tree | 9da0433cea15c840e55bbd372a792ce01ce94453 | treesnapshot (tar.gz zip) |
| parent | 24e706d52bd59f1da2ac06809e1714b24ea97d92 | commitdiff |
ppapi: VideoEncoder: prevent scheduling encoding multiple times
The ScheduleNextEncode() can be called at multiple stages in the
example depending on whether it needs to reconfigure the
MediaVideoStreamTrack. This can lead the example to encode at twice
30fps. At this speed we can exhaust the 33ms lifespan of video
buffers, leading to errors in the example plugins which can't retrieve
new frames to respect the 30fps framerate.
BUG=503153
TEST=run video_encoder example from NaCl SDK with VP8 codec and verify there are no error messages after 1 minute
Review URL: https://codereview.chromium.org/1218513003
Cr-Commit-Position: refs/heads/master@{#336850}
The ScheduleNextEncode() can be called at multiple stages in the
example depending on whether it needs to reconfigure the
MediaVideoStreamTrack. This can lead the example to encode at twice
30fps. At this speed we can exhaust the 33ms lifespan of video
buffers, leading to errors in the example plugins which can't retrieve
new frames to respect the 30fps framerate.
BUG=503153
TEST=run video_encoder example from NaCl SDK with VP8 codec and verify there are no error messages after 1 minute
Review URL: https://codereview.chromium.org/1218513003
Cr-Commit-Position: refs/heads/master@{#336850}
| native_client_sdk/src/examples/api/video_encode/video_encode.cc | diffblobblamehistory | |
| ppapi/examples/video_encode/video_encode.cc | diffblobblamehistory |