| commit | cf29998f3034bf3efae7b775add744c8d8350cfe | |
| author | jamescook <jamescook@chromium.org> | |
| Thu, 6 Nov 2014 00:30:51 +0000 (5 16:30 -0800) | ||
| committer | Commit bot <commit-bot@chromium.org> | |
| Thu, 6 Nov 2014 00:31:15 +0000 (6 00:31 +0000) | ||
| tree | f228b57517e5af6ce2ea2432ff4cc851e26b84b7 | treesnapshot (tar.gz zip) |
| parent | 0acf996ae18a5fbb4b3263af7626cbebacdd170d | commitdiff |
cros: Fix TranslateManagerRenderViewHostTest crashes in official builds
The EulaAcceptedNotifier is trying to read a preference on Chrome OS official
builds, but unit_tests don't have a PrefService (and don't need one). Skip the
pref lookup when we don't have a PrefService, which is what other tests do.
With this change all unit_tests pass on Chrome OS official/branded builds.
BUG=430637
TEST=unit_tests
Review URL: https://codereview.chromium.org/706753002
Cr-Commit-Position: refs/heads/master@{#302920}
The EulaAcceptedNotifier is trying to read a preference on Chrome OS official
builds, but unit_tests don't have a PrefService (and don't need one). Skip the
pref lookup when we don't have a PrefService, which is what other tests do.
With this change all unit_tests pass on Chrome OS official/branded builds.
BUG=430637
TEST=unit_tests
Review URL: https://codereview.chromium.org/706753002
Cr-Commit-Position: refs/heads/master@{#302920}
| chrome/browser/web_resource/eula_accepted_notifier.cc | diffblobblamehistory |