Revert of [PasswordManager] Move the sync-password-related methods to the sync layer...
commitd48a9686392f5d15987e74188dc1c366cd55ab04
authortnagel <tnagel@chromium.org>
Tue, 1 Sep 2015 13:02:53 +0000 (1 06:02 -0700)
committerCommit bot <commit-bot@chromium.org>
Tue, 1 Sep 2015 13:03:45 +0000 (1 13:03 +0000)
tree51127f0b04ee100e103b45fab90eefd3114cb982
parent13aeb042a708ad87c721b81d1a580880d8bfceef
Revert of [PasswordManager] Move the sync-password-related methods to the sync layer (patchset #15 id:320001 of https://codereview.chromium.org/1282023002/ )

Reason for revert:
This seems to break Win x64 GN (dbg):
http://build.chromium.org/p/chromium.win/builders/Win%20x64%20GN%20%28dbg%29/builds/8771

Original issue's description:
> [PasswordManager] Move the sync-password-related methods to the sync layer
>
> Instead of asking PasswordManagerClient about whether a password is a sync credential, and the client delegating this to sync_metrics in //chrome/browser/*, the client interface should delegate this to the code in the sync layer of the password_manager component.
>
> TODOs for follow-up CLs:
> (1) SyncStoreResultFilter needs to be renamed to SyncCredentialsFilter.
> (2) PasswordManager.SyncCredentialFiltered histogram needs a better description.
>
> BUG=515108,474577,514230
>
> Committed: https://crrev.com/5b5a8b4dbf5c7916fcdfe3de744eb5679914b14b
> Cr-Commit-Position: refs/heads/master@{#346631}

TBR=pavely@chromium.org,rogerta@chromium.org,engedy@chromium.org,atwilson@chromium.org,bauerb@chromium.org,blundell@chromium.org,vabr@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=515108,474577,514230

Review URL: https://codereview.chromium.org/1315503007

Cr-Commit-Position: refs/heads/master@{#346635}
28 files changed:
chrome/browser/password_manager/chrome_password_manager_client.cc
chrome/browser/password_manager/chrome_password_manager_client.h
chrome/browser/password_manager/chrome_password_manager_client_unittest.cc
chrome/browser/password_manager/password_store_factory.cc
chrome/browser/password_manager/sync_metrics.cc [new file with mode: 0644]
chrome/browser/password_manager/sync_metrics.h [new file with mode: 0644]
chrome/browser/ui/passwords/password_manager_presenter.cc
chrome/chrome_browser.gypi
components/components_tests.gyp
components/password_manager.gypi
components/password_manager/core/browser/credentials_filter.h
components/password_manager/core/browser/password_form_manager.cc
components/password_manager/core/browser/password_form_manager_unittest.cc
components/password_manager/core/browser/password_manager.cc
components/password_manager/core/browser/password_manager_client.h
components/password_manager/core/browser/password_manager_unittest.cc
components/password_manager/core/browser/stub_password_manager_client.cc
components/password_manager/core/browser/stub_password_manager_client.h
components/password_manager/sync/browser/BUILD.gn
components/password_manager/sync/browser/DEPS
components/password_manager/sync/browser/password_sync_util.cc [deleted file]
components/password_manager/sync/browser/password_sync_util.h [deleted file]
components/password_manager/sync/browser/password_sync_util_unittest.cc [deleted file]
components/password_manager/sync/browser/sync_store_result_filter.cc
components/password_manager/sync/browser/sync_store_result_filter.h
components/password_manager/sync/browser/sync_store_result_filter_unittest.cc
components/password_manager/sync/browser/sync_username_test_base.cc [deleted file]
components/password_manager/sync/browser/sync_username_test_base.h [deleted file]