| commit | d9100a6cd13ef11a282c4030a41a73a41a36289f | |
| author | ananta@chromium.org <ananta@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Wed, 29 Jan 2014 01:56:53 +0000 (29 01:56 +0000) | ||
| committer | ananta@chromium.org <ananta@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Wed, 29 Jan 2014 01:56:53 +0000 (29 01:56 +0000) | ||
| tree | 208395b8e227f963aaa6b43308c44656584374c7 | treesnapshot (tar.gz zip) |
| parent | fe35d54ca8320b91ea0dae2a172a390c0de30804 | commitdiff |
Fix the 17px dead region in the bottom right corner of top level browser windows.
This is a sideeffect of the fake WS_VSCROLL and WS_HSCROLL styles added to the window and us hiding the scrollbars
during sizing operations.
Bug does not exist on Windows 8. On Windows 7 hovering near the bottom right portion of the window where the vertical
scrollbar would be returns HTBOTTOMRIGHT instead of HTVSCROLL or HTHSCROLL which we already handle. This eventually results
in non client mouse messages like WM_NCMOUSEMOVE/WM_NCMOUSEDOWN being sent to the RWHA window which are ignored.
Attempted fix is to check in WM_NCHITTEST if the mouse coordinates are in the bottom portion of the window using metrics
like SM_CXVSCROLL/SM_CYVSCROLL/SM_CXSIZEFRAME/SM_CYSIZEFRAME and if yes convert the hittest code to HTCLIENT.
BUG=335487
R=sky@chromium.org, sky
Review URL: https://codereview.chromium.org/145513004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247584 0039d316-1c4b-4281-b951-d872f2087c98
This is a sideeffect of the fake WS_VSCROLL and WS_HSCROLL styles added to the window and us hiding the scrollbars
during sizing operations.
Bug does not exist on Windows 8. On Windows 7 hovering near the bottom right portion of the window where the vertical
scrollbar would be returns HTBOTTOMRIGHT instead of HTVSCROLL or HTHSCROLL which we already handle. This eventually results
in non client mouse messages like WM_NCMOUSEMOVE/WM_NCMOUSEDOWN being sent to the RWHA window which are ignored.
Attempted fix is to check in WM_NCHITTEST if the mouse coordinates are in the bottom portion of the window using metrics
like SM_CXVSCROLL/SM_CYVSCROLL/SM_CXSIZEFRAME/SM_CYSIZEFRAME and if yes convert the hittest code to HTCLIENT.
BUG=335487
R=sky@chromium.org, sky
Review URL: https://codereview.chromium.org/145513004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247584 0039d316-1c4b-4281-b951-d872f2087c98
| ui/views/win/hwnd_message_handler.cc | diffblobblamehistory |