| commit | db9cb0e5848645420e439277974b5aa379d83553 | |
| author | johnme <johnme@chromium.org> | |
| Tue, 12 May 2015 14:55:42 +0000 (12 07:55 -0700) | ||
| committer | Commit bot <commit-bot@chromium.org> | |
| Tue, 12 May 2015 14:56:02 +0000 (12 14:56 +0000) | ||
| tree | 87e8f7c3ea097d9f1154cd3a17fbf3a2cbf51861 | treesnapshot (tar.gz zip) |
| parent | 8fdc58112812ebd3401e49638c6c0f9cbf3779b3 | commitdiff |
Cleanup PushMessagingAppIdentifier
In particular, the IsValid method had a confusing dual purpose - it was
used both to sanity check the inputs, and to check whether the instances
returned by the Get methods were null (i.e. Get failed). It has been
split into is_null() and DCheckValid(). Note that having DCheckValid as
a method also gives better stacktraces than the old DCHECK(IsValid())
style, since stacktraces will indicate which check failed.
BUG=458592
Review URL: https://codereview.chromium.org/1131303002
Cr-Commit-Position: refs/heads/master@{#329406}
In particular, the IsValid method had a confusing dual purpose - it was
used both to sanity check the inputs, and to check whether the instances
returned by the Get methods were null (i.e. Get failed). It has been
split into is_null() and DCheckValid(). Note that having DCheckValid as
a method also gives better stacktraces than the old DCHECK(IsValid())
style, since stacktraces will indicate which check failed.
BUG=458592
Review URL: https://codereview.chromium.org/1131303002
Cr-Commit-Position: refs/heads/master@{#329406}