| commit | ddc9239a95f02f309f6296d8617f9d6799b8c4d5 | |
| author | wittman@chromium.org <wittman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Tue, 25 Feb 2014 13:41:39 +0000 (25 13:41 +0000) | ||
| committer | wittman@chromium.org <wittman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Tue, 25 Feb 2014 13:41:39 +0000 (25 13:41 +0000) | ||
| tree | 96a3ae6c5229c770a75b0a9b7dcc20891c756482 | treesnapshot (tar.gz zip) |
| parent | 01867bd2b6158f867106ae83f44e2031767f414c | commitdiff |
Support displaying browser and page actions on IDC_BOOKMARK_PAGE when overriding the bookmark shortcut
Implements the "Bookmark this page..." menu override for
Views from the Remove Bookmark Shortcut Chrome API proposal:
https://docs.google.com/a/chromium.org/document/d/1C2Mle92O9uGlji5y5gGDM5tNJ_tVE1Vb-2xgsZPNDTk
Remaining to be implemented:
- remove the "Bookmark this page..." menu item if the extension removes but does not replace the shortcut
- handling for binding to named commands rather than page/browser actions
- Cocoa support
BUG=335655
Review URL: https://codereview.chromium.org/167593002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253145 0039d316-1c4b-4281-b951-d872f2087c98
Implements the "Bookmark this page..." menu override for
Views from the Remove Bookmark Shortcut Chrome API proposal:
https://docs.google.com/a/chromium.org/document/d/1C2Mle92O9uGlji5y5gGDM5tNJ_tVE1Vb-2xgsZPNDTk
Remaining to be implemented:
- remove the "Bookmark this page..." menu item if the extension removes but does not replace the shortcut
- handling for binding to named commands rather than page/browser actions
- Cocoa support
BUG=335655
Review URL: https://codereview.chromium.org/167593002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253145 0039d316-1c4b-4281-b951-d872f2087c98
21 files changed: