| commit | de37df07399b369ce22c332ac67fb2cce38f739e | |
| author | droger <droger@chromium.org> | |
| Fri, 21 Aug 2015 16:03:57 +0000 (21 09:03 -0700) | ||
| committer | Commit bot <commit-bot@chromium.org> | |
| Fri, 21 Aug 2015 16:04:42 +0000 (21 16:04 +0000) | ||
| tree | 7c965995b31a839a0b52a809f5ab9c76db5eff74 | treesnapshot (tar.gz zip) |
| parent | 3b302defcef7b7d6df3d03db2f096fbe93ae5fac | commitdiff |
Cleanup dependencies in web_resource
This CL removes the dependencies on channel_info,
browser_process and content metrics.
The goal of this work is to enable componentization of this code,
so that it can be shared on iOS.
notification_promo_helper is introduced so that code in //chrome
does not have to explicitly pass all the arguments to the static
methods in NotificationPromo.
This will also avoid updating all the callsites when future CLs
add even more arguments.
BUG=371477
TBR=sky
Review URL: https://codereview.chromium.org/1288933002
Cr-Commit-Position: refs/heads/master@{#344779}
This CL removes the dependencies on channel_info,
browser_process and content metrics.
The goal of this work is to enable componentization of this code,
so that it can be shared on iOS.
notification_promo_helper is introduced so that code in //chrome
does not have to explicitly pass all the arguments to the static
methods in NotificationPromo.
This will also avoid updating all the callsites when future CLs
add even more arguments.
BUG=371477
TBR=sky
Review URL: https://codereview.chromium.org/1288933002
Cr-Commit-Position: refs/heads/master@{#344779}
14 files changed: