| commit | df0948695168bdc41dbb29f2c507d00f16098772 | |
| author | vabr <vabr@chromium.org> | |
| Wed, 29 Oct 2014 14:10:59 +0000 (29 07:10 -0700) | ||
| committer | Commit bot <commit-bot@chromium.org> | |
| Wed, 29 Oct 2014 14:11:15 +0000 (29 14:11 +0000) | ||
| tree | e484b1b5244f490ed83ff85a0ae6aae98b0a8af4 | treesnapshot (tar.gz zip) |
| parent | 08b0143887b593fd46819ebcebfd07b1181cf0f5 | commitdiff |
Eliminate Profile from ContentSettingsUsagesState
ContentSettingsUsagesState only used Profile to get PrefService and HostContentSettingsMap, both of which are outside //chrome. To prepare componentisation of ContentSettingsUsagesState, these are now taken directly by that class on construction, bypassing going through Profile.
Also, |TabSpecificContentSettings::profile_| is removed, because that variable was not used outside the constructor. Profile cannot be removed completely from TSCS yet, because it is used for initialising LocalSharedObjectContainers, getting the HostContentSettingsMap and PrefService. These will be addressed by subsequent CLs (by moving LSOC outside of TSCS, to the ChromeContentSettingsClient; implementing GetHostContentSettingsMap by the client; and probably the same for PrefService).
BUG=387075,387064
Review URL: https://codereview.chromium.org/688473002
Cr-Commit-Position: refs/heads/master@{#301826}
ContentSettingsUsagesState only used Profile to get PrefService and HostContentSettingsMap, both of which are outside //chrome. To prepare componentisation of ContentSettingsUsagesState, these are now taken directly by that class on construction, bypassing going through Profile.
Also, |TabSpecificContentSettings::profile_| is removed, because that variable was not used outside the constructor. Profile cannot be removed completely from TSCS yet, because it is used for initialising LocalSharedObjectContainers, getting the HostContentSettingsMap and PrefService. These will be addressed by subsequent CLs (by moving LSOC outside of TSCS, to the ChromeContentSettingsClient; implementing GetHostContentSettingsMap by the client; and probably the same for PrefService).
BUG=387075,387064
Review URL: https://codereview.chromium.org/688473002
Cr-Commit-Position: refs/heads/master@{#301826}