Revert of Remove media::VideoRenderer::SetPlaybackRate(). (https://codereview.chromiu...
commitdfb28d8eff00175d94eaf79c09e43090129adb86
authorfalken@chromium.org <falken@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Mon, 14 Jul 2014 02:48:56 +0000 (14 02:48 +0000)
committerfalken@chromium.org <falken@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Mon, 14 Jul 2014 02:48:56 +0000 (14 02:48 +0000)
tree76325388cb42c8419c40b7953ecfecc287bc28ca
parentba28fc475a8af13d6170c65a20f238e79f07e826
Revert of Remove media::VideoRenderer::SetPlaybackRate(). (https://codereview.chromium.org/384943002/)

Reason for revert:
Sorry to revert this change. It made the following layout tests flakily fail:
media/track/track-cue-rendering-horizontal.html
media/track/track-cue-rendering-vertical.html

Reverting locally healed the tests.

The image diffs show what appears to be a timestamp change (something like 0:18 to 0:19):
https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Linux__dbg_/20779/layout-test-results/results.html

Original issue's description:
> Remove media::VideoRenderer::SetPlaybackRate().
>
> Video renderers don't need the information as they are already making
> audio/video synchronization decisions based on a media timeline that
> already incorporates the current playback rate via the time callback.
>
> In particular, VideoRendererImpl only used playback rate to estimate
> a better duration to sleep until the current frame was ready ...
> except that in most cases we'd sleep for kIdleTimeDelta and wait
> until the media timeline had progressed past the current frame's
> timestamp. In other words, there's absolutely no reason to even try
> to estimate the sleep duration based on the playback rate.
>
> BUG=370634
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282797

TBR=xhwang@chromium.org,scherkus@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=370634

Review URL: https://codereview.chromium.org/390733002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282891 0039d316-1c4b-4281-b951-d872f2087c98
media/base/mock_filters.h
media/base/pipeline.cc
media/base/pipeline_unittest.cc
media/base/video_renderer.h
media/filters/video_renderer_impl.cc
media/filters/video_renderer_impl.h
media/filters/video_renderer_impl_unittest.cc