Revert of cc: Call PrepareTiles when becoming visible in browser only. (patchset...
commite13101c1f51685c13c1a2f5bafa110027ef12d70
authorjyasskin <jyasskin@chromium.org>
Mon, 20 Jul 2015 22:35:32 +0000 (20 15:35 -0700)
committerCommit bot <commit-bot@chromium.org>
Mon, 20 Jul 2015 22:36:57 +0000 (20 22:36 +0000)
treec5cc52029a086fb42b818bb05bbc865d4da05781
parentba162cdaf95c99b67da214be4cc8117db9ad2a5f
Revert of cc: Call PrepareTiles when becoming visible in browser only. (patchset #4 id:60001 of https://codereview.chromium.org/1239843002/)

Reason for revert:
LayerTreeHostTestReadyToDrawVisibility times out under DrMemory: http://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Unit%20%28DrMemory%20full%29%20%285%29/builds/4546/steps/memory%20test%3A%20cc/logs/stdio

[----------] 2 tests from LayerTreeHostTestReadyToDrawVisibility
[ RUN      ] LayerTreeHostTestReadyToDrawVisibility.RunSingleThread_DirectRenderer
c:\b\build\slave\drm-cr\build\src\cc\test\layer_tree_test.cc(875): error: Failed
Test timed out
[  FAILED  ] LayerTreeHostTestReadyToDrawVisibility.RunSingleThread_DirectRenderer (5044 ms)
[ RUN      ] LayerTreeHostTestReadyToDrawVisibility.RunSingleThread_DelegatingRenderer
c:\b\build\slave\drm-cr\build\src\cc\test\layer_tree_test.cc(875): error: Failed
Test timed out
[  FAILED  ] LayerTreeHostTestReadyToDrawVisibility.RunSingleThread_DelegatingRenderer (5244 ms)
[----------] 2 tests from LayerTreeHostTestReadyToDrawVisibility (10292 ms total)

Original issue's description:
> cc: Call PrepareTiles when becoming visible in browser only.
>
> Calling PrepareTiles on each visibility change might have caused a v8
> idle time benchmark regression. We only need to call PrepareTiles for
> the SingleThreadProxy wait for ready to draw mode.
>
> R=brianderson@chromium.org,danakj@chromium.org
> TEST=LayerTreeHostTestReadyToDrawVisibility
> BUG=499040
> CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
>
> Committed: https://crrev.com/c67e9d831fa3753fc5434229d3275b1c0155edae
> Cr-Commit-Position: refs/heads/master@{#339201}

BUG=499040

Review URL: https://codereview.chromium.org/1239363003

Cr-Commit-Position: refs/heads/master@{#339540}
cc/trees/layer_tree_host_impl.cc
cc/trees/layer_tree_host_unittest.cc
cc/trees/single_thread_proxy.cc