| commit | e6074b23a75c0e4bddffb1ce326d2c80f1dd4e3c | |
| author | blundell <blundell@chromium.org> | |
| Wed, 2 Sep 2015 11:23:58 +0000 (2 04:23 -0700) | ||
| committer | Commit bot <commit-bot@chromium.org> | |
| Wed, 2 Sep 2015 11:24:31 +0000 (2 11:24 +0000) | ||
| tree | 0bfe1bcce5535ca2af0f1ed050809d9e5b48d960 | treesnapshot (tar.gz zip) |
| parent | c18a34302ed69cb0539a29d53ab25ad7e474df59 | commitdiff |
Revert of Turn VariationsService::GetVariationsServerURL into instance method (patchset #5 id:140001 of https://codereview.chromium.org/1313213005/ )
Reason for revert:
Gak! The CreateForTesting method can't call the Create method because the latter returns null in non-official builds -- exactly the problem from the original CL :P. I don't understand why this CL passed trybots.
Original issue's description:
> Turn VariationsService::GetVariationsServerURL into instance method
>
> This will allow for followup work that uses |client_| within that
> method.
>
> Reland of https://codereview.chromium.org/1309843005 with the browsertests
> fixed to remove the unsafe accesses to g_browser_process->variations_service().
>
> BUG=516678
>
> Committed: https://crrev.com/dcc53f65eb04018ca60b077a55aa5923ac5e8e9c
> Cr-Commit-Position: refs/heads/master@{#346878}
TBR=asvitkine@chromium.org,bartfab@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=516678
Review URL: https://codereview.chromium.org/1306913003
Cr-Commit-Position: refs/heads/master@{#346884}
Reason for revert:
Gak! The CreateForTesting method can't call the Create method because the latter returns null in non-official builds -- exactly the problem from the original CL :P. I don't understand why this CL passed trybots.
Original issue's description:
> Turn VariationsService::GetVariationsServerURL into instance method
>
> This will allow for followup work that uses |client_| within that
> method.
>
> Reland of https://codereview.chromium.org/1309843005 with the browsertests
> fixed to remove the unsafe accesses to g_browser_process->variations_service().
>
> BUG=516678
>
> Committed: https://crrev.com/dcc53f65eb04018ca60b077a55aa5923ac5e8e9c
> Cr-Commit-Position: refs/heads/master@{#346878}
TBR=asvitkine@chromium.org,bartfab@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=516678
Review URL: https://codereview.chromium.org/1306913003
Cr-Commit-Position: refs/heads/master@{#346884}