Move more feedback reporting functionality upstream
commite6183698a763df520ad782d3b4c28d94bda06842
authornyquist <nyquist@chromium.org>
Tue, 16 Jun 2015 23:54:51 +0000 (16 16:54 -0700)
committerCommit bot <commit-bot@chromium.org>
Tue, 16 Jun 2015 23:55:19 +0000 (16 23:55 +0000)
treec974ba0658641c0b5fec2166b0987dbf4f444c20
parent5c1b6627fb7782433186a805b0a2e2fa5c3eeac1
Move more feedback reporting functionality upstream

Currently a lot of the feedback reporting functionality lives
downstream. This CL cleans up part of this by moving more logic
upstream.

- Adds a new interface FeedbackReporter which is implemented
  by the internal code. Upstream only a noop-version is available.
- Adds support for passing both description and screenshot through
  FeedbackCollector.
- Move the logic for reporting feedback for
  ChildAccountFeedbackReporter and DomDistillerFeedbackReporter
  to their respective classes instead of downstream.

BUG=386395, 482718

Review URL: https://codereview.chromium.org/1187143002

Cr-Commit-Position: refs/heads/master@{#334752}
13 files changed:
chrome/android/java/src/org/chromium/chrome/browser/ChromiumApplication.java
chrome/android/java/src/org/chromium/chrome/browser/child_accounts/ChildAccountFeedbackReporter.java
chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/DomDistillerFeedbackReporter.java
chrome/android/java/src/org/chromium/chrome/browser/feedback/EmptyFeedbackReporter.java [new file with mode: 0644]
chrome/android/java/src/org/chromium/chrome/browser/feedback/FeedbackCollector.java
chrome/android/java/src/org/chromium/chrome/browser/feedback/FeedbackReporter.java [new file with mode: 0644]
chrome/android/java/src/org/chromium/chrome/browser/help/HelpAndFeedback.java
chrome/android/java/src/org/chromium/chrome/browser/preferences/LearnMorePreference.java
chrome/android/java/src/org/chromium/chrome/browser/preferences/Preferences.java
chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferences.java
chrome/android/java/src/org/chromium/chrome/browser/preferences/website/TranslatePreferences.java
chrome/android/java_staging/src/org/chromium/chrome/browser/CompositorChromeActivity.java
chrome/android/java_staging/src/org/chromium/chrome/browser/ntp/IncognitoNewTabPage.java