| commit | ede293310478e0cd1061cb9f127fce053e8a01ac | |
| author | bruening@google.com <bruening@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Thu, 24 Jul 2014 02:35:07 +0000 (24 02:35 +0000) | ||
| committer | bruening@google.com <bruening@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Thu, 24 Jul 2014 02:35:07 +0000 (24 02:35 +0000) | ||
| tree | 6e8ceb49a8e078ff49a7ba039cc6b2d81b7d771c | treesnapshot (tar.gz zip) |
| parent | 72d3735a3f1723ca765b9eb0b916346115e6d875 | commitdiff |
Revert 285028 "Pepper: Remove LOAD_MODULE SRPC call in SFI mode."
Reason for revert: r285028 seems to have broken the ThreadSanitizer build.
> Pepper: Remove LOAD_MODULE SRPC call in SFI mode.
>
> This change puts nexe information in the parameters for starting a NaCl
> plugin instead of sending that information over SRPC. This may remove the
> need for that IPC round trip entirely; perhaps we could report load failure
> as part of the RPCs for starting sel_ldr or performing StartModule().
>
> nacl_defines.gypi as added as a dependency in components/components_tests.gyp
> because nacl_process_host.h now includes
> "native_client/src/public/nacl_file_info.h", which requires nacl_defines.
>
> BUG=333950
> R=bbudge@chromium.org, brettw@chromium.org, hidehiko@chromium.org, jschuh@chromium.org, mseaborn@chromium.org, sky@chromium.org
>
> Review URL: https://codereview.chromium.org/332463003
TBR=teravest@chromium.org
Review URL: https://codereview.chromium.org/413063003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285120 0039d316-1c4b-4281-b951-d872f2087c98
Reason for revert: r285028 seems to have broken the ThreadSanitizer build.
> Pepper: Remove LOAD_MODULE SRPC call in SFI mode.
>
> This change puts nexe information in the parameters for starting a NaCl
> plugin instead of sending that information over SRPC. This may remove the
> need for that IPC round trip entirely; perhaps we could report load failure
> as part of the RPCs for starting sel_ldr or performing StartModule().
>
> nacl_defines.gypi as added as a dependency in components/components_tests.gyp
> because nacl_process_host.h now includes
> "native_client/src/public/nacl_file_info.h", which requires nacl_defines.
>
> BUG=333950
> R=bbudge@chromium.org, brettw@chromium.org, hidehiko@chromium.org, jschuh@chromium.org, mseaborn@chromium.org, sky@chromium.org
>
> Review URL: https://codereview.chromium.org/332463003
TBR=teravest@chromium.org
Review URL: https://codereview.chromium.org/413063003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285120 0039d316-1c4b-4281-b951-d872f2087c98
16 files changed: