Revert of ui: Cache the output of View::OnPaint when the View isn't invalid. (patchse...
commitf2f043dcd893c280bbf8a2da9abf87c7abb50460
authorjdonnelly <jdonnelly@chromium.org>
Thu, 23 Apr 2015 20:52:49 +0000 (23 13:52 -0700)
committerCommit bot <commit-bot@chromium.org>
Thu, 23 Apr 2015 20:52:58 +0000 (23 20:52 +0000)
treec42df4eb62b5d1c849de15119332fb01df567da0
parent6d8a562e40f10b2a1e4c49f3f56c7578e3bb070d
Revert of ui: Cache the output of View::OnPaint when the View isn't invalid. (patchset #4 id:80001 of https://codereview.chromium.org/1101783002/)

Reason for revert:
ash_unittests are timing out on Win8 Aura and Linux ChromiumOS Tests (dbg)(1) bots.

Reverting this CL in order to revert https://codereview.chromium.org/1080633009/ which we suspect to be the cause of the problem.

Original issue's description:
> ui: Cache the output of View::OnPaint when the View isn't invalid.
>
> Store the output of View::OnPaint as a PaintCache object, and when the
> view has not been invalidated, use that cache output instead of doing
> work to build a recording.
>
> Performance data as follows when the loading spinner is going:
>
> Before impl-side (TOT): 0.13ms / paint
> With impl-side (no slimming paint): 0.22ms / paint
> With impl-side and slimming paint (this patch): 0.17ms / paint
>
> So this gets us some of the way there. I need to investigate why it's
> not doing more.
>
> R=piman@chromium.org, sky
> BUG=466426
>
> Committed: https://crrev.com/7f686cdcff81d6779b962e98e529a7360be2809c
> Cr-Commit-Position: refs/heads/master@{#326592}

TBR=piman@chromium.org,sky@chromium.org,danakj@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=466426

Review URL: https://codereview.chromium.org/1108463002

Cr-Commit-Position: refs/heads/master@{#326636}
12 files changed:
cc/resources/drawing_display_item.cc
cc/resources/drawing_display_item.h
ui/compositor/BUILD.gn
ui/compositor/compositor.gyp
ui/compositor/layer.cc
ui/compositor/paint_cache.cc [deleted file]
ui/compositor/paint_cache.h [deleted file]
ui/compositor/paint_context.h
ui/compositor/paint_recorder.cc
ui/compositor/paint_recorder.h
ui/views/view.cc
ui/views/view.h