| commit | f3b63c0bab333186be5848b3e0afc72d417d14cf | |
| author | sdefresne <sdefresne@chromium.org> | |
| Fri, 6 Feb 2015 15:42:17 +0000 (6 07:42 -0800) | ||
| committer | Commit bot <commit-bot@chromium.org> | |
| Fri, 6 Feb 2015 15:43:03 +0000 (6 15:43 +0000) | ||
| tree | 814c305e40d35e59085389cd813403deb8dc7578 | treesnapshot (tar.gz zip) |
| parent | f092ee226ac530125fb580485fc45765330f1a1d | commitdiff |
Remove dependency of HistoryService on WebHistoryServiceFactory
Change HistoryService::ExpireLocalAndRemoteHistoryBetween() to
receive the history::WebHistoryService instance to use in order
to remove a dependency of HistoryService on Profile.
It is not possible to pass the WebHistoryService instance to the
HistoryService constructor and add a dependency between the two
factories due to http://crbug.com/171406 (as WebHistoryService
depends on a KeyedService calling Profile::GetRequestContext()).
BUG=453790
Review URL: https://codereview.chromium.org/901803005
Cr-Commit-Position: refs/heads/master@{#315038}
Change HistoryService::ExpireLocalAndRemoteHistoryBetween() to
receive the history::WebHistoryService instance to use in order
to remove a dependency of HistoryService on Profile.
It is not possible to pass the WebHistoryService instance to the
HistoryService constructor and add a dependency between the two
factories due to http://crbug.com/171406 (as WebHistoryService
depends on a KeyedService calling Profile::GetRequestContext()).
BUG=453790
Review URL: https://codereview.chromium.org/901803005
Cr-Commit-Position: refs/heads/master@{#315038}
| chrome/browser/browsing_data/browsing_data_remover.cc | diffblobblamehistory | |
| chrome/browser/history/history_service.cc | diffblobblamehistory | |
| chrome/browser/history/history_service.h | diffblobblamehistory |