| commit | f46ff48284131eba449796a932ec32290b03a403 | |
| author | dvadym <dvadym@chromium.org> | |
| Thu, 9 Apr 2015 08:41:42 +0000 (9 01:41 -0700) | ||
| committer | Commit bot <commit-bot@chromium.org> | |
| Thu, 9 Apr 2015 08:42:16 +0000 (9 08:42 +0000) | ||
| tree | dbafcc8a4dcd758b7c25c85fc42f11f2db924423 | treesnapshot (tar.gz zip) |
| parent | 96d29c0c63677f0c67e585ee2771d1633e982155 | commitdiff |
In some cases we encounter situation when in processing onSubmit of password form we didn't receive information from password store yet. For example this can happen when JavaScript creates password form after submission and submit it (as for nytimes.com).
To process such situation this CL postpones checking if password form fetched from store until moment when we are going to decide if we should save it.
In order to process this correctly creating pending credentials in PasswordManager was moved to separate method and it is called only when both events happen - form submission and fetching from store finished.
Tests are not added yet
BUG=470322
Review URL: https://codereview.chromium.org/1050903002
Cr-Commit-Position: refs/heads/master@{#324400}
To process such situation this CL postpones checking if password form fetched from store until moment when we are going to decide if we should save it.
In order to process this correctly creating pending credentials in PasswordManager was moved to separate method and it is called only when both events happen - form submission and fetching from store finished.
Tests are not added yet
BUG=470322
Review URL: https://codereview.chromium.org/1050903002
Cr-Commit-Position: refs/heads/master@{#324400}