| commit | f9d4799b5b9c3f5c5694e24d3500a4bbe75950e9 | |
| author | dbeam <dbeam@chromium.org> | |
| Fri, 14 Aug 2015 03:20:07 +0000 (13 20:20 -0700) | ||
| committer | Commit bot <commit-bot@chromium.org> | |
| Fri, 14 Aug 2015 03:20:42 +0000 (14 03:20 +0000) | ||
| tree | 1d4fb5bd4324e5b03f2be6bd6a0d174ecfda2a0f | treesnapshot (tar.gz zip) |
| parent | f2a64e426b227a4c752be75034094b2a197288f1 | commitdiff |
More cr.ui.FocusRow simplifications
cr.ui.FocusRow no longer inherits from HTMLDivElement. Instead, it takes
a |root| argument in its constructor and uses |this.root| more.
Before there was lots of type variance. Something would start as a
<div>, then get decorated, but only work because cr.ui.FocusGrid derives
a <div>. This is clearer, more future-proof solution.
BUG=425626,518053
R=hcarmona@chromium.org,rdevlin.cronin@chromium.org
Review URL: https://codereview.chromium.org/1282043004
Cr-Commit-Position: refs/heads/master@{#343333}
cr.ui.FocusRow no longer inherits from HTMLDivElement. Instead, it takes
a |root| argument in its constructor and uses |this.root| more.
Before there was lots of type variance. Something would start as a
<div>, then get decorated, but only work because cr.ui.FocusGrid derives
a <div>. This is clearer, more future-proof solution.
BUG=425626,518053
R=hcarmona@chromium.org,rdevlin.cronin@chromium.org
Review URL: https://codereview.chromium.org/1282043004
Cr-Commit-Position: refs/heads/master@{#343333}
12 files changed: