| commit | fe788235016d6087f6bcce24f7cab9147154e751 | |
| author | engedy <engedy@chromium.org> | |
| Thu, 16 Apr 2015 15:59:43 +0000 (16 08:59 -0700) | ||
| committer | Commit bot <commit-bot@chromium.org> | |
| Thu, 16 Apr 2015 16:00:02 +0000 (16 16:00 +0000) | ||
| tree | eef66f721f0355ff201abd50e5cf2c16c22dcfd6 | treesnapshot (tar.gz zip) |
| parent | 1484e979cf3b3b181fae93b912c215b4f9c8a7b6 | commitdiff |
Fix KeychainItemForForm so that it understands not to specify a path when looking for Keychain items corresponding to Android credentials.
While other code in PasswordStoreMac omitted the path before storing the Keychain item, KeychainItemForForm derived an erroneous path for an Android credential as well, and insisted to retrieve only Keychain items having that path -- yielding no matches. This has led to deleting and updating existing passwords not working.
BUG=476851
Review URL: https://codereview.chromium.org/1089233002
Cr-Commit-Position: refs/heads/master@{#325449}
While other code in PasswordStoreMac omitted the path before storing the Keychain item, KeychainItemForForm derived an erroneous path for an Android credential as well, and insisted to retrieve only Keychain items having that path -- yielding no matches. This has led to deleting and updating existing passwords not working.
BUG=476851
Review URL: https://codereview.chromium.org/1089233002
Cr-Commit-Position: refs/heads/master@{#325449}
| chrome/browser/password_manager/password_store_mac.cc | diffblobblamehistory | |
| chrome/browser/password_manager/password_store_mac_unittest.cc | diffblobblamehistory |