| commit | ff279168dac0900c17a5dd5324208143ac517c23 | |
| author | dbeam <dbeam@chromium.org> | |
| Tue, 7 Jul 2015 00:00:07 +0000 (6 17:00 -0700) | ||
| committer | Commit bot <commit-bot@chromium.org> | |
| Tue, 7 Jul 2015 00:00:38 +0000 (7 00:00 +0000) | ||
| tree | f611b89523e91fef787beabceeaa94695064f7f5 | treesnapshot (tar.gz zip) |
| parent | bc662b13487560d77da7777bccbb7658fe68944b | commitdiff |
Fix some nits in chrome://downloads code
1) Make instance methods @private, encouraging static Manager use
2) Make a constants.js that both MD and non-MD downloads can use
3) Fix the tests to use only static downloads.Manager.* calls
4) Make onCanExecute_ easier to read
BUG=425626
R=tommycli@chromium.org
Review URL: https://codereview.chromium.org/1223893002
Cr-Commit-Position: refs/heads/master@{#337523}
1) Make instance methods @private, encouraging static Manager use
2) Make a constants.js that both MD and non-MD downloads can use
3) Fix the tests to use only static downloads.Manager.* calls
4) Make onCanExecute_ easier to read
BUG=425626
R=tommycli@chromium.org
Review URL: https://codereview.chromium.org/1223893002
Cr-Commit-Position: refs/heads/master@{#337523}
12 files changed: