From 1067392cb46b944e198f085fad7e226d700ad070 Mon Sep 17 00:00:00 2001 From: sdefresne Date: Wed, 22 Jul 2015 02:11:15 -0700 Subject: [PATCH] Remove unusued instance variable of chrome::VersionInfo. The instance variable chrome::VersionInfo::version_info_ is never used and can be safely removed. Also remove the forward-declaration of the FileVersionInfo class and the corresponding #include in the implementation file. BUG=None Review URL: https://codereview.chromium.org/1244773003 Cr-Commit-Position: refs/heads/master@{#339851} --- chrome/app/close_handle_hook_win.cc | 1 + chrome/common/chrome_version_info.cc | 1 - chrome/common/chrome_version_info.h | 7 ------- 3 files changed, 1 insertion(+), 8 deletions(-) diff --git a/chrome/app/close_handle_hook_win.cc b/chrome/app/close_handle_hook_win.cc index 4cdaf26cc65d..939818751cba 100644 --- a/chrome/app/close_handle_hook_win.cc +++ b/chrome/app/close_handle_hook_win.cc @@ -10,6 +10,7 @@ #include #include "base/lazy_instance.h" +#include "base/memory/scoped_ptr.h" #include "base/win/iat_patch_function.h" #include "base/win/pe_image.h" #include "base/win/scoped_handle.h" diff --git a/chrome/common/chrome_version_info.cc b/chrome/common/chrome_version_info.cc index 134327990ef3..996da1bca68f 100644 --- a/chrome/common/chrome_version_info.cc +++ b/chrome/common/chrome_version_info.cc @@ -5,7 +5,6 @@ #include "chrome/common/chrome_version_info.h" #include "base/basictypes.h" -#include "base/file_version_info.h" #include "base/profiler/scoped_tracker.h" #include "base/strings/utf_string_conversions.h" #include "base/threading/thread_restrictions.h" diff --git a/chrome/common/chrome_version_info.h b/chrome/common/chrome_version_info.h index 703f266daed8..b6a15aa6b7ff 100644 --- a/chrome/common/chrome_version_info.h +++ b/chrome/common/chrome_version_info.h @@ -8,9 +8,6 @@ #include #include "base/basictypes.h" -#include "base/memory/scoped_ptr.h" - -class FileVersionInfo; namespace chrome { @@ -81,10 +78,6 @@ class VersionInfo { std::string CreateVersionString() const; private: -#if defined(OS_WIN) || defined(OS_MACOSX) - scoped_ptr version_info_; -#endif - DISALLOW_COPY_AND_ASSIGN(VersionInfo); }; -- 2.11.4.GIT