From 146570309a346160cd2c78cbcdaf875b0ad60dc4 Mon Sep 17 00:00:00 2001 From: jmadill Date: Fri, 3 Oct 2014 11:46:56 -0700 Subject: [PATCH] Disable ServiceWorkerContextTest.DeleteAndStartOver on Windows. This test is failing on Windows 8. BUG=420124,416594 TBR=nhiroki@chromium.org Review URL: https://codereview.chromium.org/621373002 Cr-Commit-Position: refs/heads/master@{#298067} --- .../browser/service_worker/service_worker_context_unittest.cc | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/content/browser/service_worker/service_worker_context_unittest.cc b/content/browser/service_worker/service_worker_context_unittest.cc index 43531d6f6146..d9331ee2468c 100644 --- a/content/browser/service_worker/service_worker_context_unittest.cc +++ b/content/browser/service_worker/service_worker_context_unittest.cc @@ -339,8 +339,15 @@ TEST_F(ServiceWorkerContextTest, RegisterDuplicateScript) { EXPECT_EQ(old_registration_id, new_registration_id); } +// TODO(jmadill): Fix on Windows 8. http://crbug.com/420124 +#if defined(OS_WIN) +#define MAYBE_DeleteAndStartOver DISABLED_DeleteAndStartOver +#else +#define MAYBE_DeleteAndStartOver DeleteAndStartOver +#endif + // TODO(nhiroki): Test this for on-disk storage. -TEST_F(ServiceWorkerContextTest, DeleteAndStartOver) { +TEST_F(ServiceWorkerContextTest, MAYBE_DeleteAndStartOver) { int64 registration_id = kInvalidServiceWorkerRegistrationId; bool called = false; context()->RegisterServiceWorker( -- 2.11.4.GIT