From 186c9ac9e0bc352e0971923584ca3ae26491ece0 Mon Sep 17 00:00:00 2001 From: timurrrr Date: Tue, 17 Mar 2015 03:57:07 -0700 Subject: [PATCH] Revert of Revert of Disable a test that fails under ASan and MSan (patchset #1 id:1 of https://codereview.chromium.org/1018443002/) Reason for revert: The underlying issue is still not fixed, re-enabling the test causes bots to turn red. Please wait for the underlying issue to be resolved before re-enabling. Original issue's description: > Revert of Disable a test that fails under ASan and MSan (patchset #1 id:1 of https://codereview.chromium.org/1007293002/) > > Reason for revert: > This test is a victim of a bigger issue of main renderer message loop being used after it is deleted. Details are in crbug.com/467369. > > I've also run the test with ASAN locally and didn't reproduce after a few runs. > > Original issue's description: > > Disable a test that fails under ASan and MSan > > > > It can be flaky in other configurations as well > > > > BUG=467483 > > TBR=nasko > > > > Committed: https://crrev.com/992ff715f61e90562983139ac31392b72e716822 > > Cr-Commit-Position: refs/heads/master@{#320713} > > TBR=timurrrr@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=467483 > > Committed: https://crrev.com/216981c97018a8b8dea097cbde58889bf4e68c1a > Cr-Commit-Position: refs/heads/master@{#320755} TBR=nasko@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=467483 Review URL: https://codereview.chromium.org/1011083002 Cr-Commit-Position: refs/heads/master@{#320890} --- chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc b/chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc index 501248d12315..8de3e94774c5 100644 --- a/chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc +++ b/chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc @@ -608,7 +608,8 @@ IN_PROC_BROWSER_TEST_F(WebNavigationApiTest, History) { ASSERT_TRUE(RunExtensionTest("webnavigation/history")) << message_; } -IN_PROC_BROWSER_TEST_F(WebNavigationApiTest, CrossProcess) { +// Disabled because of http://crbug.com/467483 +IN_PROC_BROWSER_TEST_F(WebNavigationApiTest, DISABLED_CrossProcess) { ASSERT_TRUE(StartEmbeddedTestServer()); LoadExtension(test_data_dir_.AppendASCII("webnavigation").AppendASCII("app")); -- 2.11.4.GIT