From 5591967b16af40155e7feb77efd6410b6c94a4ef Mon Sep 17 00:00:00 2001 From: tfarina Date: Tue, 1 Sep 2015 16:01:00 -0700 Subject: [PATCH] tools/gn: Remove fallback to direct_dependent_configs. If public_configs were undefined we would fallback to direct_dependent_configs. we can remove this now, since we converted all the projects to public_configs already. BUG=None R=brettw@chromium.org Review URL: https://codereview.chromium.org/1307223009 Cr-Commit-Position: refs/heads/master@{#346769} --- tools/gn/target_generator.cc | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/tools/gn/target_generator.cc b/tools/gn/target_generator.cc index cd633f200018..833b382e2741 100644 --- a/tools/gn/target_generator.cc +++ b/tools/gn/target_generator.cc @@ -183,17 +183,11 @@ bool TargetGenerator::FillDependentConfigs() { if (!FillGenericConfigs(variables::kAllDependentConfigs, &target_->all_dependent_configs())) return false; + if (!FillGenericConfigs(variables::kPublicConfigs, &target_->public_configs())) return false; - // "public_configs" was previously named "direct_dependent_configs", fall - // back to that if public_configs was undefined. - if (!scope_->GetValue(variables::kPublicConfigs, false)) { - if (!FillGenericConfigs("direct_dependent_configs", - &target_->public_configs())) - return false; - } return true; } -- 2.11.4.GIT