From 6416d003916e852c9adf2f69d7cbe6582763c7fa Mon Sep 17 00:00:00 2001 From: skyostil Date: Mon, 17 Aug 2015 08:57:03 -0700 Subject: [PATCH] Don't reload twice in key_mobile_sites The Linkedin and WoW wiki pages in key_mobile_sites reload themselves before scrolling to take advantage of the browser's shader cache. However this reload is currently implemented as a reload plus a navigation. Since the navigation has more or less the same effect as a reload, the reload step is redundant. This patch removes the explicit reload step. This will make the benchmark slightly faster, and with any luck, make it less flaky[1] on some downstream bots. Note that replacing the second navigation with just the reload doesn't work because the reload does not reset the scroll offset, leaving us at the bottom of the page. [1] https://go/lhivi Review URL: https://codereview.chromium.org/1296223002 Cr-Commit-Position: refs/heads/master@{#343690} --- tools/perf/page_sets/key_mobile_sites_smooth.py | 2 -- 1 file changed, 2 deletions(-) diff --git a/tools/perf/page_sets/key_mobile_sites_smooth.py b/tools/perf/page_sets/key_mobile_sites_smooth.py index 17b1f45b9c13..577c0e9a2de8 100644 --- a/tools/perf/page_sets/key_mobile_sites_smooth.py +++ b/tools/perf/page_sets/key_mobile_sites_smooth.py @@ -49,7 +49,6 @@ class LinkedInSmoothPage(key_mobile_sites_pages.LinkedInPage): def RunNavigateSteps(self, action_runner): super(LinkedInSmoothPage, self).RunNavigateSteps(action_runner) action_runner.ScrollPage() - action_runner.ReloadPage() super(LinkedInSmoothPage, self).RunNavigateSteps(action_runner) @@ -65,7 +64,6 @@ class WowwikiSmoothPage(KeyMobileSitesSmoothPage): def RunNavigateSteps(self, action_runner): super(WowwikiSmoothPage, self).RunNavigateSteps(action_runner) action_runner.ScrollPage() - action_runner.ReloadPage() super(WowwikiSmoothPage, self).RunNavigateSteps(action_runner) -- 2.11.4.GIT