From 6fd590ab7d5ce306347fc669c9dd7c2c6e14aa63 Mon Sep 17 00:00:00 2001 From: dpranke Date: Wed, 22 Jul 2015 15:53:12 -0700 Subject: [PATCH] Clean up code nits in //tools/mb, //testing/buildbot. Minor code edits from a codereview comment for #339804. TBR=maruel@chromium.org BUG= Review URL: https://codereview.chromium.org/1256443002 Cr-Commit-Position: refs/heads/master@{#339965} --- testing/buildbot/manage.py | 2 +- tools/mb/mb.py | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/testing/buildbot/manage.py b/testing/buildbot/manage.py index ab6c3c75a993..cc8c18bf7d01 100755 --- a/testing/buildbot/manage.py +++ b/testing/buildbot/manage.py @@ -269,7 +269,7 @@ def main(): with open(os.path.join(THIS_DIR, "gn_isolate_map.pyl")) as fp: gn_isolate_map = ast.literal_eval(fp.read()) - ninja_targets = dict((k, v['label']) for k, v in gn_isolate_map.items()) + ninja_targets = {k: v['label'] for k, v in gn_isolate_map.items()} try: result = 0 diff --git a/tools/mb/mb.py b/tools/mb/mb.py index 509902f0842e..229502557c40 100755 --- a/tools/mb/mb.py +++ b/tools/mb/mb.py @@ -477,7 +477,6 @@ class MetaBuildWrapper(object): 'variables': { 'command': command, 'files': sorted(runtime_deps + extra_files), - 'read_only': 1, } }) + '\n') -- 2.11.4.GIT