From 888982f96efc790b0679daefc09860a7c13a1b8d Mon Sep 17 00:00:00 2001 From: "flackr@chromium.org" Date: Thu, 26 Sep 2013 08:53:00 +0000 Subject: [PATCH] Disable overview mode by default. BUG=297636 TEST=Without setting any flags, alt+tab and F5 do not engage overview mode. Review URL: https://codereview.chromium.org/24392004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225406 0039d316-1c4b-4281-b951-d872f2087c98 --- ash/accelerators/accelerator_controller.cc | 4 ++-- ash/ash_switches.cc | 4 ++-- ash/ash_switches.h | 2 +- chrome/browser/about_flags.cc | 8 ++++---- 4 files changed, 9 insertions(+), 9 deletions(-) diff --git a/ash/accelerators/accelerator_controller.cc b/ash/accelerators/accelerator_controller.cc index deacdbf032b2..6633a7fd45aa 100644 --- a/ash/accelerators/accelerator_controller.cc +++ b/ash/accelerators/accelerator_controller.cc @@ -88,8 +88,8 @@ bool DebugShortcutsEnabled() { } bool OverviewEnabled() { - return !CommandLine::ForCurrentProcess()->HasSwitch( - switches::kAshDisableOverviewMode); + return CommandLine::ForCurrentProcess()->HasSwitch( + switches::kAshEnableOverviewMode); } void HandleCycleBackwardMRU(const ui::Accelerator& accelerator) { diff --git a/ash/ash_switches.cc b/ash/ash_switches.cc index 791449310242..c64b090cff8a 100644 --- a/ash/ash_switches.cc +++ b/ash/ash_switches.cc @@ -125,8 +125,8 @@ const char kAshEnableMultiProfileShelfMenu[] = "ash-enable-multi-profile-shelf"; // Enables the Oak tree viewer. const char kAshEnableOak[] = "ash-enable-oak"; -// Disables overview mode for window switching. -const char kAshDisableOverviewMode[] = "ash-disable-overview-mode"; +// Enables overview mode for window switching. +const char kAshEnableOverviewMode[] = "ash-enable-overview-mode"; // Enables software based mirroring. const char kAshEnableSoftwareMirroring[] = "ash-enable-software-mirroring"; diff --git a/ash/ash_switches.h b/ash/ash_switches.h index 2302ae8624af..384c5bdb07eb 100644 --- a/ash/ash_switches.h +++ b/ash/ash_switches.h @@ -36,7 +36,6 @@ ASH_EXPORT extern const char kAshDisableDisplayChangeLimiter[]; ASH_EXPORT extern const char kAshDisableDragOffShelf[]; ASH_EXPORT extern const char kAshDisableImmersiveFullscreen[]; ASH_EXPORT extern const char kAshDisableNewLockAnimations[]; -ASH_EXPORT extern const char kAshDisableOverviewMode[]; ASH_EXPORT extern const char kAshDisableDragAndDropAppListToLauncher[]; #if defined(OS_CHROMEOS) ASH_EXPORT extern const char kAshDisableSoftwareMirroring[]; @@ -48,6 +47,7 @@ ASH_EXPORT extern const char kAshEnableAlternateFrameCaptionButtonStyle[]; ASH_EXPORT extern const char kAshEnableBrightnessControl[]; ASH_EXPORT extern const char kAshEnableDockedWindows[]; ASH_EXPORT extern const char kAshEnableImmersiveFullscreen[]; +ASH_EXPORT extern const char kAshEnableOverviewMode[]; #if defined(OS_LINUX) ASH_EXPORT extern const char kAshEnableMemoryMonitor[]; #endif diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc index a009ec5a0f35..4a53a33b5114 100644 --- a/chrome/browser/about_flags.cc +++ b/chrome/browser/about_flags.cc @@ -1088,11 +1088,11 @@ const Experiment kExperiments[] = { SINGLE_VALUE_TYPE(switches::kDisableMinimizeOnSecondLauncherItemClick) }, { - "disable-overview-mode", - IDS_FLAGS_DISABLE_OVERVIEW_MODE_NAME, - IDS_FLAGS_DISABLE_OVERVIEW_MODE_DESCRIPTION, + "enable-overview-mode", + IDS_FLAGS_OVERVIEW_MODE_NAME, + IDS_FLAGS_OVERVIEW_MODE_DESCRIPTION, kOsCrOS, - SINGLE_VALUE_TYPE(ash::switches::kAshDisableOverviewMode) + SINGLE_VALUE_TYPE(ash::switches::kAshEnableOverviewMode) }, { "show-touch-hud", -- 2.11.4.GIT